jets: remove +muk registration from /lib/tiny#887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a jet mismatch between
+mukdefinition in hoon.hoon and the jetting function that was fixed in dcb4231@urbit. Same fix could not be applied in /lib/tiny.hoon due to logistical complexities. However, the library and the naive rollup contract do not call+mukdirectly, and the mismatch is not directly observable, since it involves passing the length of the key that exceeds its size measured with+met, and+mukcallers+mugand+mumdon't do that. So it would suffice to just remove the registration from%a50root.