generate compile_commands.json#941
Merged
Merged
Conversation
Contributor
|
Great to see. Why is the macro definition (“-D”) required in addition to the custom build subcommand? |
Contributor
Author
|
It's not a macro definition, it's a boolean flag for BuildCfg struct. The code needs to be compiled with gen-cdb-fragment-path flag to generate JSON fragments (controlled by the flag), and an extra step is needed after build to merge the fragments and clean up (hence the subcommand to invoke that step) |
Contributor
|
Ok I’ll test it later and take a look at the code when I get my laptop back
in the mail. Otherwise if it works (Pyry might want to test on various
platforms) I say merge it since it doesn’t affect any critical build paths.
Thanks for writing this.
…On Mon, Jan 12, 2026 at 7:11 AM Kirill Afonin ***@***.***> wrote:
*dozreg-toplud* left a comment (urbit/vere#941)
<#941 (comment)>
It's not a macro definition, it's a boolean flag for BuildCfg struct. The
code needs to be compiled with gen-cdb-fragment-path flag to generate JSON
fragments (controlled by the flag), and an extra step is needed after build
to merge the fragments and clean up (hence the subcommand to invoke that
step)
—
Reply to this email directly, view it on GitHub
<#941 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV2DQRHLTIWFTEO6WM2OEXL4GOFONAVCNFSM6AAAAACRMYODDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMZYGI2TSMZTHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Contributor
Author
|
now only the flag is necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QoL PR: you can now generate
compile_commands.jsonfile with: