serial: minimal set of changes to allow 1 gigabyte jam in the dojo#1032
Open
pkova wants to merge 5 commits into
Open
serial: minimal set of changes to allow 1 gigabyte jam in the dojo#1032pkova wants to merge 5 commits into
pkova wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
(jam (bex (bex 32)))wouldbail: failbecause of the 32 bit implementation of the jet formet, specifically when taking the bitwise length with(met 0 atom). This PR introduces a 64 bitu3r_met_dand modifies the jamming / xeno jamming code to use it where needed.There's probably no need to keep the old
u3r_metaround in the long run but threading through the 64 bit values can be annoying so this PR scopes the work to just gettingjamworking.We also modify
cutto be less defensive with bail failing.