Skip to content

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Apr 4, 2025

What type of PR is this?

  • documentation

What this PR does / why we need it:

  • Improves migration guide v1->v2
    • fix TOC
    • tabbed snippets
  • Improves migration guide v2->v3
    • fix TOC
    • tabbed snippets

Which issue(s) this PR fixes:

No related issue.

Special notes for your reviewer:

Migrate v1 to v2 page

Screenshot 2025-04-04 at 18-18-53 Migrate v1 to v2 - urfave_cli

Migrate v2 to v3 page

Screenshot 2025-04-04 at 18-18-46 Migrate v2 to v3 - urfave_cli

Release Notes

NONE

@ldez ldez requested a review from a team as a code owner April 4, 2025 16:19
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your PR!

@dearchap dearchap merged commit 20335c6 into urfave:main Apr 6, 2025
10 checks passed
@ldez ldez deleted the feat/improve-migration-guides branch April 6, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants