-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use backport.zstd instead of zstandard #3697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
(wow, we repeat a lot of that zstd detection code, maybe this should be refactored in a follow-up PR)
| @@ -1,5 +1,5 @@ | |||
| version = 1 | |||
| revision = 3 | |||
| revision = 2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to update your uv version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm maybe I am doing something wrong, but running uv lock does not make any further changes.
I have updated uv to 0.9.4, which should be the latest version, and still the same.
Feel free to fix if you know how!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the package and this pull request!
For Python versions before 3.14, the Zstandard support is currently provided by the
zstandardlibrary. The API of this library is different from the one in the standard library (compression.zstd), which results in two different implementations of theZstdDecoderclass.This PR removes the
zstdandarddependency in favor of the backport ofcompression.zstd.Fixes #3693
Full disclosure: I'm the author and maintainer of
backports.zstd, and the maintainer ofpyzstd(which code was used as a base for the integration into Python). I also helped with PEP-784 and its integration into CPython.