Skip to content

Conversation

@schiller-manuel
Copy link

Summary

integration of @tanstack/react-router

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: cae0d95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@urql/tanstack-react-router Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

},
"main": "dist/urql-tanstack-react-router.js",
"module": "dist/urql-tanstack-react-router.es.js",
"types": "dist/urql-tanstack-react-router.d.ts",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing the export mappings, examples in other packages

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was looking at packages/react-urql/package.json which also does not have export mappings.
Why do we need export mappings here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React-urql is a special case due to some old frameworks, vite is a good bundler so we should incorporate export mappings to future proof the package. What we do with react-urql is still a bit of a pickle, especially with regards to react-native

@r614
Copy link

r614 commented Apr 22, 2025

Hi @JoviDeCroock @schiller-manuel -- just curious about the status of this. Happy to jump in and help get this across finish line

@mikaelkaron
Copy link

Also wondering on this. Would love see urql+tanstack-react-router playing along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants