Runtime: set transaction_started = 0 after db COMMIT#274
Open
buggymcbugfix wants to merge 2 commits into
Open
Conversation
Without this, when there is an error during the commit phase of a NULL rollback transactional, we get a hard error because the runtime issues a ROLLBACK command to the database, despite there being no active transaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #273 for me.
I am not very familiar with ur/web internals and I suppose I was lucky with this fix working, because after digging deeper, I am quite confused as to how a commit-phase error triggers
ctx->app->db_rollback(which causes the crash described in #273)The only places I can see that run
ctx->app->db_rollbackareuw_expungeanduw_rollback, but I don't see how either of these would be reached at this point here: https://github.com/urweb/urweb/blob/master/src/c/urweb.c#L3764-L3785