Split block requirements from item requirements#59
Merged
Conversation
AsynchWorldEdit has been abandoned for over 2 years and does not work with current server versions. We should focus on supporting FAWE going ahead.
This resolves an issue in newer Spigot versions where non-item blocks in challenge requirements prevent the plugin from loading. Fixes uskyblock#58
Member
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block and item requirements were handled identically previously for challenges. This never really made sense conceptually, as they are two different things and are treated differently internally. With Minecraft 1.21.X, this broke due to changes in how the server handles ItemStack creation. ItemStacks can no longer be obtained for Materials that are not an item, e.g., nether portal blocks.
This PR splits the implementation of item and block requirements. It fixes #58.
I removed the AWE integration because the missing dependency stopped the project from compiling. AWE has been abandoned for ~2 years and is unlikely to be revived. The focus should be on FAWE in the future if fast regeneration is desired.