Fix item enchant not being actually applied to the items in the challenge menu#73
Merged
Merged
Conversation
…challenge menu Completed challenges are usually shown with an enchant glowing effect when they are completed at least once. This may be useful for the player, but the "enchanted" status of the item is also used in the ChallengeLogic to determine if a challenge with `offset: -1` is displayed or not, in place of the completed one. New MC version, with the new data component system, does not allow an enchant level of 0 (even with unsafe enchant level), an is silently ignored. This commit changes the enchant level to 1, and adds a flag to the item meta to hide the enchant information from the tooltip.
Member
|
That's a good catch; thanks! I had noticed the offset was not working, but I did not connect it to that. We should probably make that more robust, but it'll work for now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed challenges are usually shown with an enchant glowing effect when they are completed at least once. This may be useful for the player, but the "enchanted" status of the item is also used in the ChallengeLogic to determine if a challenge with
offset: -1is displayed or not, in place of the completed one.New MC version, with the new data component system, does not allow an enchant level of 0 (even with unsafe enchant level), an is silently ignored (see decompiled source from Paper: net.minecraft.world.item.enchantment.ItemEnchantments.Mutable#set ).
This commit changes the enchant level to 1, and adds a flag to the item meta to hide the enchant information from the tooltip.