Skip to content

[platform] fix uninitialized variable#11

Closed
bryonglodencissp wants to merge 1 commit into
v8:masterfrom
bryonglodencissp:patch-1
Closed

[platform] fix uninitialized variable#11
bryonglodencissp wants to merge 1 commit into
v8:masterfrom
bryonglodencissp:patch-1

Conversation

@bryonglodencissp

@bryonglodencissp bryonglodencissp commented Sep 10, 2016

Copy link
Copy Markdown

On line number 628 of time.cc, the variable ticks may be accessed without an initialized value. And while the return value of TimeTicks::HighResolutionNow will never be zero, it's always good to initialize variables, because if we try to access a value before it gets assigned any actual (non-garbage) value, then it results in undefined behavior.

[src/base/platform/time.cc:628]: (error) Uninitialized variable: ticks

Found by https://github.com/bryongloden/cppcheck
@natorion

Copy link
Copy Markdown
Member

Thanks for the PR. V8 is not accepting PRs on GitHub. Please use the Chromium Codereview tool. More information can be found at https://github.com/v8/v8/wiki/Contributing.

@natorion natorion closed this Sep 12, 2016
@natorion

Copy link
Copy Markdown
Member

See https://bugs.chromium.org/p/chromium/issues/detail?id=646005 as the tracking bug.

@littledan

Copy link
Copy Markdown
Contributor

@bryongloden Thanks for pointing out this issue. I really appreciate contributions like this. Let me know if you have any problems following up on the bug in the Chrome bug tracker. Sorry for the extra overhead of going someplace rather than GitHub!

kisg pushed a commit to paul99/v8mips that referenced this pull request Sep 28, 2016
…zones (patchset v8#11 id:200001 of https://codereview.chromium.org/2368313002/ )

Reason for revert:
Revert due to asm.js slowdown

Original issue's description:
> Don't use different function scopes when parsing with temp zones
>
> Previously we'd have a scope in the main zone, and another in the temp zone. Then we carefully copied back data to the main zone. This CL changes it so that the scope is just fixed up to only contain data from the main zone. That avoids additional copies and additional allocations; while not increasing the care that needs to be taken. This will also make it easier to abort preparsing while parsing using a temp zone.
>
> BUG=
>
> Committed: https://crrev.com/f41e7ebd62b32e861b6aa14ad8bfce3018d03c3c
> Cr-Commit-Position: refs/heads/master@{#39800}

TBR=marja@chromium.org,adamk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2379533003
Cr-Commit-Position: refs/heads/master@{#39821}
danbev pushed a commit to danbev/v8 that referenced this pull request Sep 30, 2016
…ttps://codereview.chromium.org/2232653003/ )

Reason for revert:
Breaks benchmark with --turbo on avx2

https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/9895

Original issue's description:
> Reland of "[heap] Switch to 500k pages"
>
> Decrease regular heap object size to 400k. In a follow up, we can now get rid of
> the new space border page while keeping the 1M minimum new space size.
>
> BUG=chromium:636331
>
> This reverts commit 555c961.
>
> Committed: https://crrev.com/20e2ea80e169e85c5b8231adc02901fb6c989609
> Cr-Commit-Position: refs/heads/master@{#38608}

TBR=hpayer@chromium.org,yangguo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:636331

Review-Url: https://codereview.chromium.org/2239323002
Cr-Commit-Position: refs/heads/master@{#38613}
targos pushed a commit to nodejs/v8 that referenced this pull request Sep 30, 2016
Cr-Commit-Position: refs/branch-heads/5.4@{v8#11}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
kisg pushed a commit to paul99/v8mips that referenced this pull request Oct 14, 2016
…8#11 id:200001 of https://codereview.chromium.org/2416543002/ )

Reason for revert:
Reverting because of failure on V8 Linux64 GC Stress

http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/8572

Original issue's description:
> [wasm] Fix bounds check for zero initial memory.
>
> Currently when memory size references are updated with zero initial memory during GrowMemory/Relocation of Instance objects, the bounds check does not take into account the size of memtype.
>
> R=titzer@chromium.org, bradnelson@chromium.org
>
> Committed: https://crrev.com/70416a2b360c0d993cffb48284b143d484d1e290
> Cr-Commit-Position: refs/heads/master@{#40326}

TBR=bradnelson@chromium.org,titzer@chromium.org,bradnelson@google.com,mtrofin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2416393002
Cr-Commit-Position: refs/heads/master@{#40328}
targos pushed a commit to nodejs/v8 that referenced this pull request Nov 5, 2016
Cr-Commit-Position: refs/branch-heads/5.5@{v8#11}
Cr-Branched-From: 3cbd583-refs/heads/5.5.372@{#1}
Cr-Branched-From: b3c8b0c-refs/heads/master@{#40015}
cameni pushed a commit to Outerra/v8 that referenced this pull request Nov 30, 2016
Revision: 9d1d387

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=joransiu@ca.ibm.com, jyan@ca.ibm.com
BUG=

Review-Url: https://codereview.chromium.org/2525813002
Cr-Commit-Position: refs/branch-heads/5.6@{v8#11}
Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1}
Cr-Branched-From: 879f659-refs/heads/master@{#41014}
kisg pushed a commit to paul99/v8mips that referenced this pull request Dec 14, 2016
…ed by their ID (patchset v8#11 id:190001 of https://codereview.chromium.org/2547483002/ )

Reason for revert:
LiveEdit is broken in some cases.

Original issue's description:
> Store SharedFunctionInfos of a Script in a FixedArray indexed by their ID
>
> Now that SharedFunctionInfos have a unique ID (and the IDs are dense),
> we can use them as an index into an array, instead of using a
> WeakFixedArray where we have to do a linear scan.
>
> Hooking up liveedit is a bit more involved, see
> https://docs.google.com/presentation/d/1FtNa3U7WsF5bPhY9uGoJG5Y9hnz5VBDabfOWpb4unWI/edit
> for an overview
>
> BUG=v8:5589
> R=verwaest@chromium.org,jgruber@chromium.org
>
> Committed: https://crrev.com/6595e7405769dc9d49e9568d61485efc6d468baf
> Cr-Commit-Position: refs/heads/master@{#41600}

TBR=jgruber@chromium.org,verwaest@chromium.org,yangguo@chromium.org,jochen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5589,chromium:673950
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2578433002
Cr-Commit-Position: refs/heads/master@{#41684}
kisg pushed a commit to paul99/v8mips that referenced this pull request Dec 22, 2016
…ls slots (patchset v8#11 id:370001 of https://codereview.chromium.org/2504153002/ )

Reason for revert:
Speculative revert because of blocked roll: https://codereview.chromium.org/2596013002/

Original issue's description:
> [TypeFeedbackVector] Root literal arrays in function literals slots
>
> Literal arrays and feedback vectors for a function can be garbage
> collected if we don't have a rooted closure for the function, which
> happens often. It's expensive to come back from this (recreating
> boilerplates and gathering feedback again), and the cost is
> disproportionate if the function was inlined into optimized code.
>
> To guard against losing these arrays when we need them, we'll now
> create literal arrays when creating the feedback vector for the outer
> closure, and root them strongly in that vector.
>
> BUG=v8:5456
>
> Review-Url: https://codereview.chromium.org/2504153002
> Cr-Commit-Position: refs/heads/master@{#41893}
> Committed: https://chromium.googlesource.com/v8/v8/+/93df094081f04c629c3df2e40318de90ce5e0fb9

TBR=bmeurer@chromium.org,mlippautz@chromium.org,mvstanton@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5456

Review-Url: https://codereview.chromium.org/2597163002
Cr-Commit-Position: refs/heads/master@{#41917}
hubot pushed a commit that referenced this pull request Dec 22, 2016
Merged aa8a208

Revert of [TypeFeedbackVector] Root literal arrays in function literals slots (patchset #11 id:370001 of https://codereview.chromium.org/2504153002/ )

TBR=jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2592393002 .
Cr-Commit-Position: refs/heads/5.7.324@{#3}
Cr-Branched-From: 2041c50-refs/heads/master@{#41902}
kisg pushed a commit to paul99/v8mips that referenced this pull request Jan 17, 2017
… with compiler dispatcher. (patchset v8#11 id:260001 of https://codereview.chromium.org/2611313002/ )

Reason for revert:
Some crashes on mac:
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/11982/steps/Ignition%20-%20turbofan/logs/regress-crbug-429159
https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/10966

Original issue's description:
> [complier] Enable parallel eager inner function compilation with compiler dispatcher.
>
> Enable enqueueing of eager inner function compilation onto the compiler
> dispatcher. This enables these tasks to be performed in parallel to
> compilation of the outer functio (only for Ignition functions).
> We currently synchronize to ensure all inner function compilations
>  are complete before executing the outer function - future work will
> allow outer function execution to happenin parallel to inner function
> compilation.
>
> BUG=v8:5203,v8:5215
>
> Review-Url: https://codereview.chromium.org/2611313002
> Cr-Commit-Position: refs/heads/master@{#42413}
> Committed: https://chromium.googlesource.com/v8/v8/+/f12661a1ece4e9c9cb8df5c2d349db960356e604

TBR=jochen@chromium.org,marja@chromium.org,mstarzinger@chromium.org,rmcilroy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5203,v8:5215

Review-Url: https://codereview.chromium.org/2637123002
Cr-Commit-Position: refs/heads/master@{#42416}
hubot pushed a commit that referenced this pull request Jan 19, 2017
Cr-Commit-Position: refs/branch-heads/5.7@{#11}
Cr-Branched-From: 975e9a3-refs/heads/5.7.492@{#1}
Cr-Branched-From: 8d76f0e-refs/heads/master@{#42426}
hubot pushed a commit that referenced this pull request Mar 2, 2017
Revision: ef2a9e2

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2728763005
Cr-Commit-Position: refs/branch-heads/5.8@{#11}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
hubot pushed a commit that referenced this pull request Apr 17, 2017
Revision: 136c712

BUG=chromium:711195,v8:5267,v8:6241
TBR=jarin@chromium.org
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: Id6e9bf726c268d525c33b363b4358d565b41535f
Reviewed-on: https://chromium-review.googlesource.com/479731
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/branch-heads/5.9@{#11}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Cr-Commit-Position: refs/branch-heads/5.3@{#11}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Merged 9b7035d

LookupIterator should find private symbols on JSProxies

BUG=chromium:571365
LOG=N
TBR=hablich@chromium.org

Review URL: https://codereview.chromium.org/1612093004 .

Cr-Commit-Position: refs/branch-heads/4.9@{#11}
Cr-Branched-From: 2fea296-refs/heads/4.9.385@{#1}
Cr-Branched-From: 0c1430a-refs/heads/master@{#33306}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Merged 6e281f1

[heap] Fix SemiSpace::Commit/GrowTo to deal with OOM

BUG=chromium:581412,chromium:601041,chromium:601417
LOG=N
R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/1892043002 .

Cr-Commit-Position: refs/branch-heads/5.1@{#11}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Merged b71f1cc

Bugfix: Crankshaft array literals with incorrect values.

BUG=chromium:606021
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/2010503002 .

Cr-Commit-Position: refs/branch-heads/5.2@{#11}
Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1}
Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Cr-Commit-Position: refs/branch-heads/4.7@{#11}
Cr-Branched-From: f3c8926-refs/heads/master@{#31014}
hubot pushed a commit that referenced this pull request Apr 28, 2017
BUG=chromium:318206
R=jkummerow@chromium.org, hablich@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/1751843002 .

Cr-Commit-Position: refs/branch-heads/5.0@{#11}
Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1}
Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
hubot pushed a commit that referenced this pull request Apr 28, 2017
Merged 833fb7d
Merged 9864129

[debugger] track debugger feature usage via histogram.

[debugger] only track LiveEdit if source changes.

R=yangguo@chromium.org
BUG=v8:4596

Review URL: https://codereview.chromium.org/1510433002 .

Cr-Commit-Position: refs/branch-heads/4.8@{#11}
Cr-Branched-From: 10449d4-refs/heads/4.8.271@{#1}
Cr-Branched-From: 2ebd5fc-refs/heads/master@{#31941}
kisg pushed a commit to paul99/v8mips that referenced this pull request May 18, 2017
…tps://codereview.chromium.org/2847923003/ )

Reason for revert:
Seems to have made nosnap debug very slow and also leads to check failures:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/13248

Original issue's description:
> [csa] Add assertions to CSA
>
> This adds a bunch of assertions to CSA, mostly about documenting and checking
> parameter types.
>
> Drive-by-change: Removed unused function.
>
> BUG=v8:6325
>
> Review-Url: https://codereview.chromium.org/2847923003
> Cr-Commit-Position: refs/heads/master@{#45398}
> Committed: https://chromium.googlesource.com/v8/v8/+/b14a981496ad1f841683479d2f9188dfa2d6b4bd

TBR=cbruni@chromium.org,ishell@chromium.org,jgruber@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:6325

Review-Url: https://codereview.chromium.org/2892023002
Cr-Commit-Position: refs/heads/master@{#45401}
hubot pushed a commit that referenced this pull request Jun 1, 2017
… registers."

This reverts commit 16d77bb.

Reason for revert: breaks build

Original change's description:
> Merged: [Interpreter] Allocate context registers as temporary registers.
> 
> Revision: c68df41
> 
> BUG=chromium:716265,v8:6322
> LOG=N
> NOTRY=true
> NOPRESUBMIT=true
> NOTREECHECKS=true
> R=​mythria
> 
> Change-Id: Ieaf426865f90c4dc8d59a4c1e545748e7b7b34e2
> Reviewed-on: https://chromium-review.googlesource.com/519169
> Reviewed-by: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/branch-heads/6.0@{#9}
> Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{#1}
> Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}

TBR=rmcilroy@chromium.org,mythria@chromium.org
BUG=chromium:716265,v8:6322

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I5f04c3f27c246e00654e5c786c7f55e9d0b758e8
Reviewed-on: https://chromium-review.googlesource.com/519410
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.0@{#11}
Cr-Branched-From: 97dbf62-refs/heads/6.0.286@{#1}
Cr-Branched-From: 12e6f1c-refs/heads/master@{#45439}
hubot pushed a commit that referenced this pull request Jul 26, 2017
TBR=machenbach@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I86963f2c155ae3db46e470f5d6f20503fe67c7d1
Reviewed-on: https://chromium-review.googlesource.com/585975
Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.1@{#11}
Cr-Branched-From: 1bf2e10-refs/heads/6.1.534@{#1}
Cr-Branched-From: e825c43-refs/heads/master@{#46746}
hubot pushed a commit that referenced this pull request Sep 11, 2017
Revision: b1c1228

BUG=chromium:739902
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=bmeurer@chromium.org

Change-Id: I9b6ddf251e08667983a49005441e8931b5511418
Reviewed-on: https://chromium-review.googlesource.com/660098
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.2@{#11}
Cr-Branched-From: efa2ac4-refs/heads/6.2.414@{#1}
Cr-Branched-From: a861ebb-refs/heads/master@{#47693}
hubot pushed a commit that referenced this pull request Oct 17, 2017
…cts.

Revision: 6aa9f43

BUG=chromium:763073
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=bmeurer@chromium.org

Change-Id: If8a8ebf9e176e862912010deb1a54ae484bd45e3
Reviewed-on: https://chromium-review.googlesource.com/722639
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.3@{#11}
Cr-Branched-From: 094a7c9-refs/heads/6.3.292@{#1}
Cr-Branched-From: 18b8fbb-refs/heads/master@{#48432}
billti pushed a commit to billti/v8 that referenced this pull request Apr 6, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I31a9954779f122be8139296356a76c39c44d1ec4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049864
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.1@{v8#11}
Cr-Branched-From: a4dcd39-refs/heads/8.1.307@{#1}
Cr-Branched-From: f22c213-refs/heads/master@{#66031}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Sep 2, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I4b63796a3d0fb0081c0e5fdb0fd6b08116d6a740
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2279029
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#11}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ic43bafa4dc4b5a4a9fb2f02374ff7e62d759e807
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1802152
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.8@{v8#11}
Cr-Branched-From: 73694fd-refs/heads/7.8.279@{#1}
Cr-Branched-From: 2314928-refs/heads/master@{#63555}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I7ef69985a2fe02f74ca88d8d25e031345c6f9bae
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1771336
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.7@{v8#11}
Cr-Branched-From: 4035531-refs/heads/7.7.299@{#1}
Cr-Branched-From: 1320c91-refs/heads/master@{#62881}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
Revision: b3270b8

BUG=v8:9146
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=machenbach@chromium.com

Change-Id: If72019152f4f980123ebc9bdc2cd3a1731149d7a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870233
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Cr-Commit-Position: refs/branch-heads/7.9@{v8#11}
Cr-Branched-From: be181e2-refs/heads/7.9.317@{#1}
Cr-Branched-From: 0d7889d-refs/heads/master@{#64307}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ieae8f2934e269003f3d7f173eb6302107f3b6643
Reviewed-on: https://chromium-review.googlesource.com/c/1446135
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.3@{v8#11}
Cr-Branched-From: 9df9418-refs/heads/7.3.492@{v8#2}
Cr-Branched-From: be213cf-refs/heads/master@{#59024}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I4473066053ed4c945a381aacf6868d9efaaae6a8
Reviewed-on: https://chromium-review.googlesource.com/c/1296393
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.1@{v8#11}
Cr-Branched-From: f70aaa8-refs/heads/7.1.302@{#1}
Cr-Branched-From: 1dbcc78-refs/heads/master@{#56462}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I72304175355a22bcc7d0895c17d202da7a0aa5aa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1652156
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.6@{v8#11}
Cr-Branched-From: 2cb2573-refs/heads/7.6.303@{#1}
Cr-Branched-From: 201c509-refs/heads/master@{#61902}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ib25930ee97effc42f122759cc5359978e2839a54
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588157
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7.5@{v8#11}
Cr-Branched-From: 35b9bf5-refs/heads/7.5.288@{#1}
Cr-Branched-From: 912b391-refs/heads/master@{#60911}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I4d9966250b61f62869ecbe8e80955ff487107393
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150113
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.3@{v8#11}
Cr-Branched-From: 1668abd-refs/heads/8.3.110@{#1}
Cr-Branched-From: 04a7a68-refs/heads/master@{#66926}
ceejatec pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Sep 24, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I21f79a7f204461fd35efca62be696c0627ab29db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2209153
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.4@{v8#11}
Cr-Branched-From: 88ed2e3-refs/heads/8.4.371@{#1}
Cr-Branched-From: 35f88bf-refs/heads/master@{#67773}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Oct 28, 2020
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie9d9bf2b723d0f6c5b9454a6d7c1e46ce0f65987
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416910
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#11}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Feb 6, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I64f790856e25188f65d8950c1356845cc99d203f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2560965
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.8@{v8#11}
Cr-Branched-From: 2dbcdc1-refs/heads/8.8.278@{#1}
Cr-Branched-From: 366d30c-refs/heads/master@{#71094}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Apr 29, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ibb710364da11abddb84048fbfac10f04669dc5cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2731345
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#11}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I1b8f9d168b3c1c55dcc737cbf76890816eb66a6c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2822927
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#11}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
salewski pushed a commit to salewski/v8 that referenced this pull request Aug 26, 2021
Revision: e165544

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=pthier@chromium.org

Bug: chromium:1236978
Change-Id: Ifc4b29b7c6b889a12dd43991c6032c6a053a95b5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3097462
Reviewed-by: Patrick Thier <pthier@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#11}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jun 27, 2022
Change-Id: I1eec64ea8ccbd7f93297e4a30ecbd0f2209cd0bd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3565174
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.1@{v8#11}
Cr-Branched-From: b003970-refs/heads/10.1.124@{#1}
Cr-Branched-From: e62f556-refs/heads/main@{#79503}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ie0edd2186f71fbb01c48648f669a0b46a42ad62c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931898
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#11}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: Idb09496ef9491b3995ba11099c8a31be5c3aaffa
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3826071
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.5@{v8#11}
Cr-Branched-From: 51c4d6c-refs/heads/10.5.218@{#1}
Cr-Branched-From: c641530-refs/heads/main@{#81851}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Ifd7d979d97512b4629cdca16487f5f32eb9dc2c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2632874
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#11}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: Ia411cb1321e83530938159f7efa195c15a901c72
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3668843
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.3@{v8#11}
Cr-Branched-From: 1a8f4ca-refs/heads/10.3.174@{#1}
Cr-Branched-From: 8fbefa4-refs/heads/main@{#80471}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: I27dffeb19378b1ceb466c0f58ce5078493fb3fd4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3507195
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.0@{v8#11}
Cr-Branched-From: 6ea73a7-refs/heads/10.0.139@{#1}
Cr-Branched-From: ccc6890-refs/heads/main@{#79131}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I621037f404fe5e6fd2a747701a354201b8f821ff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3164276
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#11}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Port 1ab14ed

This reverts commit 08607d3.

Bug: v8:13203
Change-Id: I7fc424fe1a5dedf8fa26cba2c46b29ae6d08937c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3845790
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#11}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: If53dc1516e60fc36245219793bf224578b735aef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439632
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.9@{v8#11}
Cr-Branched-From: c4208cc-refs/heads/9.9.115@{#1}
Cr-Branched-From: 19c6fd7-refs/heads/main@{#78682}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I64037645651b1d925ad33b03507a25493fd37be0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3228789
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#11}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: Ibe09dd0b3958b97f6c27e9b97edf4439cc2f4904
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687171
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.2@{v8#11}
Cr-Branched-From: 374091f-refs/heads/10.2.154@{#1}
Cr-Branched-From: f0c353f-refs/heads/main@{#79976}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
This reverts commit c14b3e4.

Reason for revert: https://crbug.com/1335195

Original change's description:
> [regalloc] add hint for operands in gap moves.
>
> To eliminate unnecessary move instructions from register to fixed register. We check the fixed register hint for operands in move gaps
> when building LiveRanges. If a to_operand has a hint_operand (with fixed register), then set the hint_operand for from_operand too. This can avoid the register allocator ignore hint information about fixed register.
>
> Bug: v8:12909
> Change-Id: I17f9afa484ee08de8ac1ab42945caba2c362fc9e
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3669019
> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
> Commit-Queue: Jialu Zhang <jialu.zhang@intel.com>
> Cr-Commit-Position: refs/heads/main@{#80844}

(cherry picked from commit b22fcf9)

Bug: v8:12909, chromium:1335195
Change-Id: Iedba9244a75074e448c5e85880cc202866b91e71
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3706988
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.4@{v8#11}
Cr-Branched-From: b1413ed-refs/heads/10.4.132@{#1}
Cr-Branched-From: 9d0a093-refs/heads/main@{#80972}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Change-Id: Ic24ff5b00cb283b6b75837e7e76240c17af5a154
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3387104
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.8@{v8#11}
Cr-Branched-From: e218afa-refs/heads/9.8.177@{#1}
Cr-Branched-From: 86ebfc9-refs/heads/main@{#78312}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I2c3ed263c32236b130a66c3f00b717bbdfe0b3f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3055254
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.3@{v8#11}
Cr-Branched-From: 7744dce-refs/heads/9.3.345@{#1}
Cr-Branched-From: 4b6b4ca-refs/heads/master@{#75728}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants