If FreeBSD is Linux then so is OpenBSD#5
Conversation
This makes landmine work on OpenBSD. I haven't detected any negative effects from this, but I haven't used it extensively.
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 20, 2015
… (patchset v8#5 id:80001 of https://codereview.chromium.org/1405313002/ ) Reason for revert: Breaks nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug%20-%202/builds/2407/steps/Check/logs/regress-4395 Original issue's description: > [es6] Fix scoping for default parameters in arrow functions > > When eagerly parsing arrow functions, expressions in default > parameter initializers are parsed in the enclosing scope, > rather than in the function's scope (since that scope does not > yet exist). This leads to VariableProxies being added to the > wrong scope, and scope chains for FunctionLiterals being incorrect. > > This patch addresses these problems by adding a subclass of > AstExpressionVisitor that moves VariableProxies to the proper > scope and fixes up scope chains of FunctionLiterals. > > More work likely still needs to be done to make this work completely, > but it's very close to correct. > > BUG=v8:4395 > LOG=y > > Committed: https://crrev.com/cf72aad39e51de9b7074ea039377c1812f4a2c6b > Cr-Commit-Position: refs/heads/master@{#31402} TBR=rossberg@chromium.org,caitpotter88@gmail.com,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4395 Review URL: https://codereview.chromium.org/1417463004 Cr-Commit-Position: refs/heads/master@{#31404}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 21, 2015
…chset v8#5 id:90008 of https://codereview.chromium.org/1415733004/ ) Reason for revert: Failing again: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/2183 Original issue's description: > Reland of "[heap] Divide available memory upon compaction tasks" > > This reverts commit cf71c28. > > Original message: > > [heap] Divide available memory upon compaction tasks > - Fairly (round-robin) divide available memory upon compaction tasks. > - Ensure an upper limit (of memory) since dividing is O(n) for n free-space > nodes. > - Refill from free lists managed by sweeper once a compaction space becomes > empty. > > Assumption for dividing memory: Memory in the free lists is sparse upon starting > compaction (which means that only few nodes are available), except for memory > reducer GCs, which happen in idle time though (so it's less of a problem). > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/63f42ecb965d04877f45043c1416170b6f79b962 > Cr-Commit-Position: refs/heads/master@{#31436} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1405273003 Cr-Commit-Position: refs/heads/master@{#31439}
jshagam
pushed a commit
to HBOCodeLabs/v8
that referenced
this pull request
Oct 27, 2015
The current implemention breaks sloppy mode code that uses function declarations inside blocks at top-level. Work is ongoing on a patch to fix this issue, but in the meantime it seems reasonable to move the feature out of staging. Manual revert of commit 6e07f5a. Cherry-picked of bab3b55 TBR=littledan@chromium.org,adamk@chromium.org BUG=chromium:535836 LOG=y Review URL: https://codereview.chromium.org/1375213005 Cr-Commit-Position: refs/heads/master@{#31029} Review URL: https://codereview.chromium.org/1387563002 . Cr-Commit-Position: refs/branch-heads/4.7@{v8#5} Cr-Branched-From: f3c8926-refs/heads/master@{#31014}
mtbrandy
added a commit
that referenced
this pull request
Nov 13, 2015
Merged 8779afc Merged b237b8a Merged 59a0641 Merged f83b8a6 PPC: Fix trampoline pool blocking. PPC: [turbofan] Fix trampoline pool blocking. Fix test-heap/LargeObjectSlotRecording. Skip test-run-machops/RunComputedCodeObject on AIX and PPC64BE. R=jkummerow@chromium.org, hablich@chromium.org BUG= Review URL: https://codereview.chromium.org/1440293003 . Cr-Commit-Position: refs/branch-heads/4.8@{#5} Cr-Branched-From: 10449d4-refs/heads/4.8.271@{#1} Cr-Branched-From: 2ebd5fc-refs/heads/master@{#31941}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 24, 2015
…8#5 id:80001 of https://codereview.chromium.org/1469543003/ ) Reason for revert: [Sheriff] This breaks ignition on arm sim debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5317 Seems to not be caught by the cq bot that builds release with dchecks. Original issue's description: > Disable non-standard Promise functions in staging > > This patch removes Promise functions and methods which are absent > from the ES2015 specification when the --es-staging flag is on. > > BUG=v8:3237 > R=rossberg > LOG=Y > > Committed: https://crrev.com/941251af7e04d50ac2243da2870249a42111221a > Cr-Commit-Position: refs/heads/master@{#32194} TBR=rossberg@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3237 Review URL: https://codereview.chromium.org/1473603002 Cr-Commit-Position: refs/heads/master@{#32199}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 24, 2015
…id:80001 of https://codereview.chromium.org/1451843002/ ) Reason for revert: Fails on V8 Fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/6028 Original issue's description: > Move --harmony-destructuring-bind to shipping > > Also fix CheckConflictingVarDeclarations() to properly handle > legacy const bindings. Without that change enabling the flag > causes code like: > > function f() { const x; var x; } > > to throw an early error, rather than wait to throw the error > until f is invoked. > > BUG=v8:811 > LOG=y > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/515093630a4a925a66d550561e38293d49633f10 > Cr-Commit-Position: refs/heads/master@{#32222} TBR=rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Review URL: https://codereview.chromium.org/1470333002 Cr-Commit-Position: refs/heads/master@{#32226}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 24, 2015
… #1 id:1 of https://codereview.chromium.org/1473603002/ ) Reason for revert: Breakage in Ignition seems unrelated; relanding. Original issue's description: > Revert of Disable non-standard Promise functions in staging (patchset v8#5 id:80001 of https://codereview.chromium.org/1469543003/ ) > > Reason for revert: > [Sheriff] This breaks ignition on arm sim debug: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5317 > > Seems to not be caught by the cq bot that builds release with dchecks. > > Original issue's description: > > Disable non-standard Promise functions in staging > > > > This patch removes Promise functions and methods which are absent > > from the ES2015 specification when the --es-staging flag is on. > > > > BUG=v8:3237 > > R=rossberg > > LOG=Y > > > > Committed: https://crrev.com/941251af7e04d50ac2243da2870249a42111221a > > Cr-Commit-Position: refs/heads/master@{#32194} > > TBR=rossberg@chromium.org,littledan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3237 > > Committed: https://crrev.com/86bd2b3c23b562213d5af158849dcd65f347a827 > Cr-Commit-Position: refs/heads/master@{#32199} TBR=rossberg@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3237 Review URL: https://codereview.chromium.org/1478533002 Cr-Commit-Position: refs/heads/master@{#32235}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 25, 2015
…ttps://codereview.chromium.org/1467133006/ ) Reason for revert: failure here https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosse4/builds/6842/steps/Check/logs/RandomBitCorrelations12 Original issue's description: > Add test to check PRNG quality. > > Credits go to Erik Corry. Taken from: > https://github.com/dart-lang/fletch/blob/master/src/shared/random_test.cc > > R=jkummerow@chromium.org > BUG=v8:4566 > LOG=N > > Committed: https://crrev.com/1a90af55d1e9d7d84e813dc367d475457c7df1ff > Cr-Commit-Position: refs/heads/master@{#32211} > > Committed: https://crrev.com/3d84f05cd77091ea8dde7821973f13f53dbaa730 > Cr-Commit-Position: refs/heads/master@{#32238} > > Committed: https://crrev.com/eeee7ab050013782704b5f89e49d06a30b3455c4 > Cr-Commit-Position: refs/heads/master@{#32246} TBR=jkummerow@chromium.org,erikcorry@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4566 Review URL: https://codereview.chromium.org/1472833004 Cr-Commit-Position: refs/heads/master@{#32247}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 1, 2015
…ors. (patchset v8#5 id:80001 of https://codereview.chromium.org/1470253002/ ) Reason for revert: Still investigating bad canary. Original issue's description: > [heap] Refactor evacuation for young and old gen into visitors. > > Create a visitor for evacuating objects for young and old generation. This is > the first step of preparing a task to process, both, newspace and oldspace > pages in parallel. > > BUG=chromium:524425 > LOG=N > > Committed: https://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8 > Cr-Commit-Position: refs/heads/master@{#32349} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1483393002 Cr-Commit-Position: refs/heads/master@{#32462}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 2, 2015
…ors. (patchset #1 id:1 of https://codereview.chromium.org/1483393002/ ) Reason for revert: Reland after fixing the potential root cause of the canary crasher. Original issue's description: > Revert of [heap] Refactor evacuation for young and old gen into visitors. (patchset v8#5 id:80001 of https://codereview.chromium.org/1470253002/ ) > > Reason for revert: > Still investigating bad canary. > > Original issue's description: > > [heap] Refactor evacuation for young and old gen into visitors. > > > > Create a visitor for evacuating objects for young and old generation. This is > > the first step of preparing a task to process, both, newspace and oldspace > > pages in parallel. > > > > BUG=chromium:524425 > > LOG=N > > > > Committed: https://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8 > > Cr-Commit-Position: refs/heads/master@{#32349} > > TBR=mlippautz@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:524425 > > Committed: https://crrev.com/aa24a3135ec308e1f84bce334844caf0cae2437a > Cr-Commit-Position: refs/heads/master@{#32462} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1493523003 Cr-Commit-Position: refs/heads/master@{#32500}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 2, 2015
…ors. (patchset #1 id:1 of https://codereview.chromium.org/1493523003/ ) Reason for revert: Speculative revert for crashing Canary. Original issue's description: > Reland of [heap] Refactor evacuation for young and old gen into visitors. (patchset #1 id:1 of https://codereview.chromium.org/1483393002/ ) > > Reason for revert: > Reland after fixing the potential root cause of the canary crasher. > > Original issue's description: > > Revert of [heap] Refactor evacuation for young and old gen into visitors. (patchset v8#5 id:80001 of https://codereview.chromium.org/1470253002/ ) > > > > Reason for revert: > > Still investigating bad canary. > > > > Original issue's description: > > > [heap] Refactor evacuation for young and old gen into visitors. > > > > > > Create a visitor for evacuating objects for young and old generation. This is > > > the first step of preparing a task to process, both, newspace and oldspace > > > pages in parallel. > > > > > > BUG=chromium:524425 > > > LOG=N > > > > > > Committed: https://crrev.com/138d9bae5d7014e0d205634a49b5eac3697744c8 > > > Cr-Commit-Position: refs/heads/master@{#32349} > > > > TBR=mlippautz@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=chromium:524425 > > > > Committed: https://crrev.com/aa24a3135ec308e1f84bce334844caf0cae2437a > > Cr-Commit-Position: refs/heads/master@{#32462} > > TBR=mlippautz@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:524425 > > Committed: https://crrev.com/120b640dfce5f02cecc5af72ca0b2b3b93ce8652 > Cr-Commit-Position: refs/heads/master@{#32500} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Review URL: https://codereview.chromium.org/1495583002 Cr-Commit-Position: refs/heads/master@{#32522}
littledan
added a commit
that referenced
this pull request
Dec 2, 2015
… #1 id:1 of https://codereview.chromium.org/1478533002/ ) Reason for revert: Will test better; there seems to be a bug related to this. Original issue's description: > Reland of Disable non-standard Promise functions in staging (patchset #1 id:1 of https://codereview.chromium.org/1473603002/ ) > > Reason for revert: > Breakage in Ignition seems unrelated; relanding. > > Original issue's description: > > Revert of Disable non-standard Promise functions in staging (patchset #5 id:80001 of https://codereview.chromium.org/1469543003/ ) > > > > Reason for revert: > > [Sheriff] This breaks ignition on arm sim debug: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/5317 > > > > Seems to not be caught by the cq bot that builds release with dchecks. > > > > Original issue's description: > > > Disable non-standard Promise functions in staging > > > > > > This patch removes Promise functions and methods which are absent > > > from the ES2015 specification when the --es-staging flag is on. > > > > > > BUG=v8:3237 > > > R=rossberg > > > LOG=Y > > > > > > Committed: https://crrev.com/941251af7e04d50ac2243da2870249a42111221a > > > Cr-Commit-Position: refs/heads/master@{#32194} > > > > TBR=rossberg@chromium.org,littledan@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=v8:3237 > > > > Committed: https://crrev.com/86bd2b3c23b562213d5af158849dcd65f347a827 > > Cr-Commit-Position: refs/heads/master@{#32199} > > TBR=rossberg@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3237 > > Committed: https://crrev.com/9278b7b05a45c2089007e8b61822af96b5d0c8df > Cr-Commit-Position: refs/heads/master@{#32235} TBR=rossberg@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3237 Review URL: https://codereview.chromium.org/1493713004 Cr-Commit-Position: refs/heads/master@{#32530}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 17, 2015
…nd Reflect.apply. (patchset v8#5 id:80001 of https://codereview.chromium.org/1523753002/ ) Reason for revert: Breaks TSAN somewhow: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/7000 Original issue's description: > [es6] Correct Function.prototype.apply, Reflect.construct and Reflect.apply. > > Introduce a new Apply builtin that forms a correct and optimizable > foundation for the Function.prototype.apply, Reflect.construct and > Reflect.apply builtins (which properly does the PrepareForTailCall > as required by the ES2015 spec). > > The new Apply builtin avoids going to the runtime if it is safe to > just access the backing store elements of the argArray, i.e. if you > pass a JSArray with no holes, or an unmapped, unmodified sloppy or > strict arguments object. > > mips/mips64 ports by Balazs Kilvady <balazs.kilvady@imgtec.com> > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > BUG=v8:4413, v8:4430 > LOG=n > R=yangguo@chromium.org > > Committed: https://chromium.googlesource.com/v8/v8/+/e4d2538911f6cb4b626830ccbb3c1f5746542697 TBR=yangguo@chromium.org,paul.lind@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4413, v8:4430 Review URL: https://codereview.chromium.org/1533803002 . Cr-Commit-Position: refs/heads/master@{#32928}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 29, 2015
…id:80001 of https://codereview.chromium.org/1541233002/ ) Reason for revert: [Sheriff] Changes layout tests. Please fix upstream first if intended. https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 Original issue's description: > Use ES2015-style TypedArray prototype chain > > This patch switches TypedArrays to use the prototype chain described > in the ES2015 specification, which adds a %TypedArray% superclass above > all individual TypedArray types. Most methods are defined on the > superclass rather than the subclasses. > > In order to prevent a performance regression, a few methods are > marked as inline. Inlining might prevent code which was previously > monomorphic from becoming polymorphic, and it was specifically > applied in places where methods became more polymorphic than before. > Tests with realistic workloads would be nice to do before this > ships in stable. > > This patch does not bring TypedArrays up to full spec compliance. In > particular, @@species is not yet supported. > > R=cbruni > BUG=v8:4085 > LOG=Y > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > Cr-Commit-Position: refs/heads/master@{#33050} TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4085 Review URL: https://codereview.chromium.org/1554523002 Cr-Commit-Position: refs/heads/master@{#33053}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 30, 2015
…:1 of https://codereview.chromium.org/1554523002/ ) Reason for revert: Should be fixed again with this Blink change to add NeedsManualRebaseline Original issue's description: > Revert of Use ES2015-style TypedArray prototype chain (patchset v8#5 id:80001 of https://codereview.chromium.org/1541233002/ ) > > Reason for revert: > [Sheriff] Changes layout tests. Please fix upstream first if intended. > > https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3689 > > Original issue's description: > > Use ES2015-style TypedArray prototype chain > > > > This patch switches TypedArrays to use the prototype chain described > > in the ES2015 specification, which adds a %TypedArray% superclass above > > all individual TypedArray types. Most methods are defined on the > > superclass rather than the subclasses. > > > > In order to prevent a performance regression, a few methods are > > marked as inline. Inlining might prevent code which was previously > > monomorphic from becoming polymorphic, and it was specifically > > applied in places where methods became more polymorphic than before. > > Tests with realistic workloads would be nice to do before this > > ships in stable. > > > > This patch does not bring TypedArrays up to full spec compliance. In > > particular, @@species is not yet supported. > > > > R=cbruni > > BUG=v8:4085 > > LOG=Y > > > > Committed: https://crrev.com/07c91dccbe55c7be3ec75857dee5ad59873330b7 > > Cr-Commit-Position: refs/heads/master@{#33050} > > TBR=caitpotter88@gmail.com,cbruni@chromium.org,littledan@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4085 > > Committed: https://crrev.com/28b55ffd1e32e09aaf42b8bbb407944d4808e07c > Cr-Commit-Position: refs/heads/master@{#33053} TBR=caitpotter88@gmail.com,cbruni@chromium.org,machenbach@chromium.org BUG=v8:4085 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1558663002 Cr-Commit-Position: refs/heads/master@{#33067}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Feb 17, 2016
…hset v8#5 id:80001 of https://codereview.chromium.org/1702593002/ ) Reason for revert: [Sheriff] Breaks nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/5329 Original issue's description: > More simplification and unification of frame handling > > Frame slots indexes numbers are used more consistently for > computation in both TurboFan and Crankshaft. Specifically, > Crankshaft now uses frame slot indexes in LChunk, removing > the need for some special-case maths when building the > deoptimization translation table. > > LOG=N > R=mstarzinger@chromium.org > > Committed: https://crrev.com/81423b84dbb2eaf7e1a57b0f6029fc8e643b4755 > Cr-Commit-Position: refs/heads/master@{#34078} TBR=mstarzinger@chromium.org,jarin@chromium.org,danno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1708583002 Cr-Commit-Position: refs/heads/master@{#34082}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Feb 17, 2016
… id:80001 of https://codereview.chromium.org/1686233002/ ) Reason for revert: [Sheriff] Breaks arm cross-compile: https://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20debug%20builder/builds/7825/ Original issue's description: > Add Scoped Context Info (Isolate) to V8 Traces > > This patch adds the newly added support for contexts in V8 Tracing, as well > as use it to mark all the entry points for a V8 Isolate. > > BUG=v8:4565 > LOG=N > > Committed: https://crrev.com/44823c3c6965966c63b7e2e2361d0f2a58d196ea > Cr-Commit-Position: refs/heads/master@{#34092} TBR=jochen@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4565 Review URL: https://codereview.chromium.org/1710573002 Cr-Commit-Position: refs/heads/master@{#34095}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 9, 2016
…odereview.chromium.org/1748123003/ ) Reason for revert: Breaks Chromium. Original issue's description: > Rework CallApi*Stubs. > > - Eliminate stubs with a variable number of arguments. > (That only worked due to their very limited use. These > stubs' interface descriptors were basically lying > about their number of args, which will fail when used > generically.) > - Fix all CallApi*Stubs' interface descriptors to no > longer lie about their arguments. > - Unify CallApi*Stub, for * in Function, Accessor, > FunctionWithFixedArgs. > (Since these are now all doing the same thing.) > - Rename the unified stub (and interface descriptors) to > *ApiCallback*, since that's really what they're doing. > - Refuse inlining an API callback if its number of > parameters exceeds the supported number of args. > > BUG= > > Committed: https://crrev.com/d238b953a474272c0e3ea22ef6a9b63fa9729340 > Cr-Commit-Position: refs/heads/master@{#34614} TBR=danno@chromium.org,jkummerow@chromium.org,mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1775933005 Cr-Commit-Position: refs/heads/master@{#34624}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 2, 2016
…70001 of https://codereview.chromium.org/1848433003/ ) Reason for revert: [Sheriff] Speculative revert. Compile now times out on msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/7705 Original issue's description: > Turbofan: Add MachineOperators for SIMD. > > Takes the SIMD runtime intrinsics as a starting point for defining TF machine operators. The rationale for omitting functions is: > > - UInt constructors. int and uint aren't distinguished in wasm. > - Check functions. > - 'FromXxxBits' functions. These are essentially casts. > - Simple Load / Store functions. Existing load / store with SIMD type should work. > - Uint functions, except where their behavior is bitwise different from the Int function. > > Skipped fns: > > Float32x4Check > Float32x4FromInt32x4Bits > Float32x4FromUint32x4Bits > Float32x4FromInt16x8Bits > Float32x4FromUint16x8Bits > Float32x4FromInt8x16Bits > Float32x4FromUint8x16Bits > Float32x4Load > Float32x4Store > > Int32x4Check > Int32x4FromUint32x4 > Int32x4FromFloat32x4Bits > Int32x4FromUint32x4Bits > Int32x4FromInt16x8Bits > Int32x4FromUint16x8Bits > Int32x4FromInt8x16Bits > Int32x4FromUint8x16Bits > Int32x4Load > Int32x4Store > > CreateUint32x4 > Uint32x4Check > Uint32x4ExtractLane > Uint32x4ReplaceLane > Uint32x4Add > Uint32x4Sub > Uint32x4Mul > Uint32x4And > Uint32x4Or > Uint32x4Xor > Uint32x4Not > Uint32x4Equal > Uint32x4NotEqual > Uint32x4Select > Uint32x4Swizzle > Uint32x4Shuffle > Uint32x4FromInt32x4 > Uint32x4FromFloat32x4Bits > Uint32x4FromInt32x4Bits > Uint32x4FromInt16x8Bits > Uint32x4FromUint16x8Bits > Uint32x4FromInt8x16Bits > Uint32x4FromUint8x16Bits > Uint32x4Load > Uint32x4Load1 > Uint32x4Load2 > Uint32x4Load3 > Uint32x4Store > Uint32x4Store1 > Uint32x4Store2 > Uint32x4Store3 > > Bool32x4Check > > Int16x8Check > Int16x8FromUint16x8 > Int16x8FromFloat32x4Bits > Int16x8FromInt32x4Bits > Int16x8FromUint32x4Bits > Int16x8FromUint16x8Bits > Int16x8FromInt8x16Bits > Int16x8FromUint8x16Bits > Int16x8Load > Int16x8Store > > CreateUint16x8 > Uint16x8Check > Uint16x8ExtractLane > Uint16x8ReplaceLane > Uint16x8Add > Uint16x8Sub > Uint16x8Mul > Uint16x8And > Uint16x8Or > Uint16x8Xor > Uint16x8Not > Uint16x8Equal > Uint16x8NotEqual > Uint16x8Select > Uint16x8Swizzle > Uint16x8Shuffle > Uint16x8FromInt16x8 > Uint16x8FromFloat32x4Bits > Uint16x8FromInt32x4Bits > Uint16x8FromUint32x4Bits > Uint16x8FromInt16x8Bits > Uint16x8FromInt8x16Bits > Uint16x8FromUint8x16Bits > Uint16x8Load > Uint16x8Store > > Bool16x8Check > > Int8x16Check > Int8x16FromUint8x16 > Int8x16FromFloat32x4Bits > Int8x16FromInt32x4Bits > Int8x16FromUint32x4Bits > Int8x16FromInt16x8Bits > Int8x16FromUint16x8Bits > Int8x16FromUint8x16Bits > Int8x16Load > Int8x16Store > > CreateUint8x16 > Uint8x16Check > Uint8x16ExtractLane > Uint8x16ReplaceLane > Uint8x16Add > Uint8x16Sub > Uint8x16Mul > Uint8x16And > Uint8x16Or > Uint8x16Xor > Uint8x16Not > Uint8x16Equal > Uint8x16NotEqual > Uint8x16Select > Uint8x16Swizzle > Uint8x16Shuffle > Uint8x16FromInt8x16 > Uint8x16FromFloat32x4Bits > Uint8x16FromInt32x4Bits > Uint8x16FromUint32x4Bits > Uint8x16FromInt16x8Bits > Uint8x16FromUint16x8Bits > Uint8x16FromInt8x16Bits > Uint8x16Load > Uint8x16Store > > Bool8x16Check > > LOG=N > BUG=v8:4124 > > Committed: https://crrev.com/3831d41e4ce7b162775732cb6ac1f8139e60aa30 > Cr-Commit-Position: refs/heads/master@{#35213} TBR=bradnelson@chromium.org,gdeepti@chromium.org,titzer@chromium.org,mtrofin@chromium.org,bradnelson@google.com,bmeurer@chromium.org,bbudge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1850373002 Cr-Commit-Position: refs/heads/master@{#35220}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 2, 2016
https://codereview.chromium.org/1850373002/ ) Reason for revert: Revert didn't help. Still we need to figure out what bothers the msan build. Original issue's description: > Revert of Turbofan: Add MachineOperators for SIMD. (patchset v8#5 id:70001 of https://codereview.chromium.org/1848433003/ ) > > Reason for revert: > [Sheriff] Speculative revert. Compile now times out on msan: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/7705 > > Original issue's description: > > Turbofan: Add MachineOperators for SIMD. > > > > Takes the SIMD runtime intrinsics as a starting point for defining TF machine operators. The rationale for omitting functions is: > > > > - UInt constructors. int and uint aren't distinguished in wasm. > > - Check functions. > > - 'FromXxxBits' functions. These are essentially casts. > > - Simple Load / Store functions. Existing load / store with SIMD type should work. > > - Uint functions, except where their behavior is bitwise different from the Int function. > > > > Skipped fns: > > > > Float32x4Check > > Float32x4FromInt32x4Bits > > Float32x4FromUint32x4Bits > > Float32x4FromInt16x8Bits > > Float32x4FromUint16x8Bits > > Float32x4FromInt8x16Bits > > Float32x4FromUint8x16Bits > > Float32x4Load > > Float32x4Store > > > > Int32x4Check > > Int32x4FromUint32x4 > > Int32x4FromFloat32x4Bits > > Int32x4FromUint32x4Bits > > Int32x4FromInt16x8Bits > > Int32x4FromUint16x8Bits > > Int32x4FromInt8x16Bits > > Int32x4FromUint8x16Bits > > Int32x4Load > > Int32x4Store > > > > CreateUint32x4 > > Uint32x4Check > > Uint32x4ExtractLane > > Uint32x4ReplaceLane > > Uint32x4Add > > Uint32x4Sub > > Uint32x4Mul > > Uint32x4And > > Uint32x4Or > > Uint32x4Xor > > Uint32x4Not > > Uint32x4Equal > > Uint32x4NotEqual > > Uint32x4Select > > Uint32x4Swizzle > > Uint32x4Shuffle > > Uint32x4FromInt32x4 > > Uint32x4FromFloat32x4Bits > > Uint32x4FromInt32x4Bits > > Uint32x4FromInt16x8Bits > > Uint32x4FromUint16x8Bits > > Uint32x4FromInt8x16Bits > > Uint32x4FromUint8x16Bits > > Uint32x4Load > > Uint32x4Load1 > > Uint32x4Load2 > > Uint32x4Load3 > > Uint32x4Store > > Uint32x4Store1 > > Uint32x4Store2 > > Uint32x4Store3 > > > > Bool32x4Check > > > > Int16x8Check > > Int16x8FromUint16x8 > > Int16x8FromFloat32x4Bits > > Int16x8FromInt32x4Bits > > Int16x8FromUint32x4Bits > > Int16x8FromUint16x8Bits > > Int16x8FromInt8x16Bits > > Int16x8FromUint8x16Bits > > Int16x8Load > > Int16x8Store > > > > CreateUint16x8 > > Uint16x8Check > > Uint16x8ExtractLane > > Uint16x8ReplaceLane > > Uint16x8Add > > Uint16x8Sub > > Uint16x8Mul > > Uint16x8And > > Uint16x8Or > > Uint16x8Xor > > Uint16x8Not > > Uint16x8Equal > > Uint16x8NotEqual > > Uint16x8Select > > Uint16x8Swizzle > > Uint16x8Shuffle > > Uint16x8FromInt16x8 > > Uint16x8FromFloat32x4Bits > > Uint16x8FromInt32x4Bits > > Uint16x8FromUint32x4Bits > > Uint16x8FromInt16x8Bits > > Uint16x8FromInt8x16Bits > > Uint16x8FromUint8x16Bits > > Uint16x8Load > > Uint16x8Store > > > > Bool16x8Check > > > > Int8x16Check > > Int8x16FromUint8x16 > > Int8x16FromFloat32x4Bits > > Int8x16FromInt32x4Bits > > Int8x16FromUint32x4Bits > > Int8x16FromInt16x8Bits > > Int8x16FromUint16x8Bits > > Int8x16FromUint8x16Bits > > Int8x16Load > > Int8x16Store > > > > CreateUint8x16 > > Uint8x16Check > > Uint8x16ExtractLane > > Uint8x16ReplaceLane > > Uint8x16Add > > Uint8x16Sub > > Uint8x16Mul > > Uint8x16And > > Uint8x16Or > > Uint8x16Xor > > Uint8x16Not > > Uint8x16Equal > > Uint8x16NotEqual > > Uint8x16Select > > Uint8x16Swizzle > > Uint8x16Shuffle > > Uint8x16FromInt8x16 > > Uint8x16FromFloat32x4Bits > > Uint8x16FromInt32x4Bits > > Uint8x16FromUint32x4Bits > > Uint8x16FromInt16x8Bits > > Uint8x16FromUint16x8Bits > > Uint8x16FromInt8x16Bits > > Uint8x16Load > > Uint8x16Store > > > > Bool8x16Check > > > > LOG=N > > BUG=v8:4124 > > > > Committed: https://crrev.com/3831d41e4ce7b162775732cb6ac1f8139e60aa30 > > Cr-Commit-Position: refs/heads/master@{#35213} > > TBR=bradnelson@chromium.org,gdeepti@chromium.org,titzer@chromium.org,mtrofin@chromium.org,bradnelson@google.com,bmeurer@chromium.org,bbudge@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4124 > > Committed: https://crrev.com/8481ec6016992e0b9ffb70137e9ff8fcd4135bba > Cr-Commit-Position: refs/heads/master@{#35220} TBR=bradnelson@chromium.org,gdeepti@chromium.org,titzer@chromium.org,mtrofin@chromium.org,bradnelson@google.com,bmeurer@chromium.org,bbudge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1850383002 Cr-Commit-Position: refs/heads/master@{#35221}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 2, 2016
https://codereview.chromium.org/1850383002/ ) Reason for revert: The first revert did help after all. See comments on: https://codereview.chromium.org/1848433003/ Original issue's description: > Reland of Turbofan: Add MachineOperators for SIMD. (patchset #1 id:1 of https://codereview.chromium.org/1850373002/ ) > > Reason for revert: > Revert didn't help. Still we need to figure out what bothers the msan build. > > Original issue's description: > > Revert of Turbofan: Add MachineOperators for SIMD. (patchset v8#5 id:70001 of https://codereview.chromium.org/1848433003/ ) > > > > Reason for revert: > > [Sheriff] Speculative revert. Compile now times out on msan: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/7705 > > > > Original issue's description: > > > Turbofan: Add MachineOperators for SIMD. > > > > > > Takes the SIMD runtime intrinsics as a starting point for defining TF machine operators. The rationale for omitting functions is: > > > > > > - UInt constructors. int and uint aren't distinguished in wasm. > > > - Check functions. > > > - 'FromXxxBits' functions. These are essentially casts. > > > - Simple Load / Store functions. Existing load / store with SIMD type should work. > > > - Uint functions, except where their behavior is bitwise different from the Int function. > > > > > > Skipped fns: > > > > > > Float32x4Check > > > Float32x4FromInt32x4Bits > > > Float32x4FromUint32x4Bits > > > Float32x4FromInt16x8Bits > > > Float32x4FromUint16x8Bits > > > Float32x4FromInt8x16Bits > > > Float32x4FromUint8x16Bits > > > Float32x4Load > > > Float32x4Store > > > > > > Int32x4Check > > > Int32x4FromUint32x4 > > > Int32x4FromFloat32x4Bits > > > Int32x4FromUint32x4Bits > > > Int32x4FromInt16x8Bits > > > Int32x4FromUint16x8Bits > > > Int32x4FromInt8x16Bits > > > Int32x4FromUint8x16Bits > > > Int32x4Load > > > Int32x4Store > > > > > > CreateUint32x4 > > > Uint32x4Check > > > Uint32x4ExtractLane > > > Uint32x4ReplaceLane > > > Uint32x4Add > > > Uint32x4Sub > > > Uint32x4Mul > > > Uint32x4And > > > Uint32x4Or > > > Uint32x4Xor > > > Uint32x4Not > > > Uint32x4Equal > > > Uint32x4NotEqual > > > Uint32x4Select > > > Uint32x4Swizzle > > > Uint32x4Shuffle > > > Uint32x4FromInt32x4 > > > Uint32x4FromFloat32x4Bits > > > Uint32x4FromInt32x4Bits > > > Uint32x4FromInt16x8Bits > > > Uint32x4FromUint16x8Bits > > > Uint32x4FromInt8x16Bits > > > Uint32x4FromUint8x16Bits > > > Uint32x4Load > > > Uint32x4Load1 > > > Uint32x4Load2 > > > Uint32x4Load3 > > > Uint32x4Store > > > Uint32x4Store1 > > > Uint32x4Store2 > > > Uint32x4Store3 > > > > > > Bool32x4Check > > > > > > Int16x8Check > > > Int16x8FromUint16x8 > > > Int16x8FromFloat32x4Bits > > > Int16x8FromInt32x4Bits > > > Int16x8FromUint32x4Bits > > > Int16x8FromUint16x8Bits > > > Int16x8FromInt8x16Bits > > > Int16x8FromUint8x16Bits > > > Int16x8Load > > > Int16x8Store > > > > > > CreateUint16x8 > > > Uint16x8Check > > > Uint16x8ExtractLane > > > Uint16x8ReplaceLane > > > Uint16x8Add > > > Uint16x8Sub > > > Uint16x8Mul > > > Uint16x8And > > > Uint16x8Or > > > Uint16x8Xor > > > Uint16x8Not > > > Uint16x8Equal > > > Uint16x8NotEqual > > > Uint16x8Select > > > Uint16x8Swizzle > > > Uint16x8Shuffle > > > Uint16x8FromInt16x8 > > > Uint16x8FromFloat32x4Bits > > > Uint16x8FromInt32x4Bits > > > Uint16x8FromUint32x4Bits > > > Uint16x8FromInt16x8Bits > > > Uint16x8FromInt8x16Bits > > > Uint16x8FromUint8x16Bits > > > Uint16x8Load > > > Uint16x8Store > > > > > > Bool16x8Check > > > > > > Int8x16Check > > > Int8x16FromUint8x16 > > > Int8x16FromFloat32x4Bits > > > Int8x16FromInt32x4Bits > > > Int8x16FromUint32x4Bits > > > Int8x16FromInt16x8Bits > > > Int8x16FromUint16x8Bits > > > Int8x16FromUint8x16Bits > > > Int8x16Load > > > Int8x16Store > > > > > > CreateUint8x16 > > > Uint8x16Check > > > Uint8x16ExtractLane > > > Uint8x16ReplaceLane > > > Uint8x16Add > > > Uint8x16Sub > > > Uint8x16Mul > > > Uint8x16And > > > Uint8x16Or > > > Uint8x16Xor > > > Uint8x16Not > > > Uint8x16Equal > > > Uint8x16NotEqual > > > Uint8x16Select > > > Uint8x16Swizzle > > > Uint8x16Shuffle > > > Uint8x16FromInt8x16 > > > Uint8x16FromFloat32x4Bits > > > Uint8x16FromInt32x4Bits > > > Uint8x16FromUint32x4Bits > > > Uint8x16FromInt16x8Bits > > > Uint8x16FromUint16x8Bits > > > Uint8x16FromInt8x16Bits > > > Uint8x16Load > > > Uint8x16Store > > > > > > Bool8x16Check > > > > > > LOG=N > > > BUG=v8:4124 > > > > > > Committed: https://crrev.com/3831d41e4ce7b162775732cb6ac1f8139e60aa30 > > > Cr-Commit-Position: refs/heads/master@{#35213} > > > > TBR=bradnelson@chromium.org,gdeepti@chromium.org,titzer@chromium.org,mtrofin@chromium.org,bradnelson@google.com,bmeurer@chromium.org,bbudge@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=v8:4124 > > > > Committed: https://crrev.com/8481ec6016992e0b9ffb70137e9ff8fcd4135bba > > Cr-Commit-Position: refs/heads/master@{#35220} > > TBR=bradnelson@chromium.org,gdeepti@chromium.org,titzer@chromium.org,mtrofin@chromium.org,bradnelson@google.com,bmeurer@chromium.org,bbudge@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4124 > > Committed: https://crrev.com/1f46e3ee8cec6b06b30b569e5688de095c4661ff > Cr-Commit-Position: refs/heads/master@{#35221} TBR=bradnelson@chromium.org,gdeepti@chromium.org,titzer@chromium.org,mtrofin@chromium.org,bradnelson@google.com,bmeurer@chromium.org,bbudge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1846413002 Cr-Commit-Position: refs/heads/master@{#35222}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 11, 2016
…n-monomorphic-cache (patchset v8#5 id:80001 of https://codereview.chromium.org/1864703003/ ) Reason for revert: [Sheriff] Check during mksnapshot: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/5950/steps/compile/logs/stdio Original issue's description: > Turn StoreIC::Megamorphic into a builtin, get rid of the non-monomorphic-cache > > BUG= > > Committed: https://crrev.com/8764f87a3399ba433a4ce6f32161181c713af95c > Cr-Commit-Position: refs/heads/master@{#35376} TBR=mvstanton@chromium.org,hpayer@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1875033003 Cr-Commit-Position: refs/heads/master@{#35379}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 14, 2016
…ttps://codereview.chromium.org/1854713002/ ) Reason for revert: performance impact Original issue's description: > Correctly annotate eval origin. > > There were a couple of issues with it: > - interpreter is not supported > - the source position was just accidentally correct for full-codegen > - the eval origin could have been cached > > Also fixes a few other places to use AbstractCode. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/2f3a171adc9e620c2235bf0562145b9d4eaba66d > Cr-Commit-Position: refs/heads/master@{#35257} > > Committed: https://crrev.com/ad4e8a27963b704bb70ec8bac0991c57296b1d16 > Cr-Commit-Position: refs/heads/master@{#35481} TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1888013002 Cr-Commit-Position: refs/heads/master@{#35491}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 27, 2016
…:120001 of https://codereview.chromium.org/1913083002/ ) Reason for revert: Creates a spike of OOM(v8) crashers on Win32. Original issue's description: > [heap] Uncommit pooled pages concurrently > > - Move the concurrent unmapping to MemoryAllocator > - Hide (private) members where possible > - MemoryAllocator:Free is now the bottleneck for freeing > - Pooled pages are either allocated from a set of pooled pages are obtained > through work stealing from the concurrent unmapper > > BUG=chromium:605866, chromium:581412 > LOG=N > > Committed: https://crrev.com/2158df87116906160cebc3ad20c97f454822da03 > Cr-Commit-Position: refs/heads/master@{#35797} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:605866, chromium:581412 Review URL: https://codereview.chromium.org/1925563003 Cr-Commit-Position: refs/heads/master@{#35819}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 29, 2016
…v8#5 id:80001 of https://codereview.chromium.org/1904313004/ ) Reason for revert: [Sheriff] Looks like this breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/6442 Original issue's description: > Remove more dead code after Object.observe removal > > This moves __{define,lookup}{Getter,Setter}__ to builtins.cc to free up the JavaScript implementation of DefineOwnProperty for deletion. TBR=verwaest@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1929293002 Cr-Commit-Position: refs/heads/master@{#35886}
southerngs
pushed a commit
to southerngs/v8-git-mirror
that referenced
this pull request
May 3, 2016
Merged cf8de86 Fix annotated disassembly in ll_prof.py R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1871013002 Cr-Commit-Position: refs/branch-heads/5.1@{v8#5} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 20, 2016
…id:80001 of https://codereview.chromium.org/2156923002/ ) Reason for revert: Blocks roll: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1622 Original issue's description: > [builtins] Introduce a builtin for Abort(). > > Calling Runtime::kAbort through a builtin instead of the c-entry stub > will allow to generate the call in a background thread, because a > builtin provides its own handle, whereas a code stub does not. > > @v8-mips-ports: Could you take a special look at the padding that is > done in MacroAssembler::Abort()? > > R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org, v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com > > Committed: https://crrev.com/9be015a254cfff871c56cd129523a729637e9158 > Cr-Commit-Position: refs/heads/master@{#37854} TBR=bmeurer@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,v8-arm-ports@googlegroups.com,v8-mips-ports@googlegroups.com,akos.palfi@imgtec.com,ahaas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2163603003 Cr-Commit-Position: refs/heads/master@{#37883}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 20, 2016
…8#5 id:80001 of https://codereview.chromium.org/2156923002/ ). port 3e8f49a (r37883) original commit message: Reason for revert: Blocks roll: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/builds/1622 Original issue's description: > [builtins] Introduce a builtin for Abort(). > > Calling Runtime::kAbort through a builtin instead of the c-entry stub > will allow to generate the call in a background thread, because a > builtin provides its own handle, whereas a code stub does not. > > @v8-mips-ports: Could you take a special look at the padding that is > done in MacroAssembler::Abort()? > > R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org, v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com > > Committed: https://crrev.com/9be015a254cfff871c56cd129523a729637e9158 > Cr-Commit-Position: refs/heads/master@{#37854} BUG= Review-Url: https://codereview.chromium.org/2168573002 Cr-Commit-Position: refs/heads/master@{#37888}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Aug 8, 2016
…atchset v8#5 id:80001 of https://codereview.chromium.org/2225843002/ ) Reason for revert: Revert as asan bot blocks the clusterfuzz uploads: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20ASAN/builds/14256 https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN Please add more skips on reland. Original issue's description: > [test] Split TurboFan mjsunit expectations for variants. > > R=machenbach@chromium.org > > Committed: https://crrev.com/5eed70c6b474635ccdf111e2269dbf33e629ce0b > Cr-Commit-Position: refs/heads/master@{#38445} TBR=mstarzinger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2227733002 Cr-Commit-Position: refs/heads/master@{#38446}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Aug 9, 2016
…chset v8#5 id:80001 of https://codereview.chromium.org/2180273002/ ) Reason for revert: Times out webgl errors: https://bugs.chromium.org/p/chromium/issues/detail?id=635545 Original issue's description: > [KeyedLoadIC] Support Smi "handlers" for element loads > > This is an experiment as far as performance is concerned. If Smi-configured > element loading directly from the dispatcher stub is fast enough, then we > can stop compiling LoadFastElementStubs (and drop the corresponding code). > > Committed: https://crrev.com/c9308147b341596de2733039223918a6202afa5f > Cr-Commit-Position: refs/heads/master@{#38377} BUG=chromium:635545 TBR=ishell@chromium.org,jkummerow@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2222273003 Cr-Commit-Position: refs/heads/master@{#38473}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Aug 25, 2016
…. (patchset v8#5 id:80001 of https://codereview.chromium.org/2266823002/ ) Reason for revert: Octane/Mandreel aborts with an exception now: TypeError: __FUNCTION_TABLE__[(r2 >> 2)] is not a function Original issue's description: > [turbofan] Insert dummy values when changing from None type. > > Currently we choose the MachineRepresentation::kNone representation for > values of Type::None, and when converting values from the kNone representation > we use "impossible" conversions that will crash at runtime. This > assumes that the impossible conversions should never be hit (the only > way to produce the impossible values is to perform an always-failing > runtime check on a value, such as Smi-checking a string). Note that > this assumes that the runtime check is executed before the impossible > convesrion. > > Introducing BitwiseOr type feedback broke this in two ways: > > - we always pick Word32 representation for bitwise-or, so the > impossible conversion does not trigger (it only triggers with > None representation), and we could end up with unsupported > conversions from Word32. > > - even if we inserted impossible conversions, they are pure conversions. > Since untagging, bitwise-or operations are also pure, we could hoist > all these before the smi check of the inputs and we could hit the > impossible conversions before we get to the smi check. > > This CL addresses this by just providing dummy values for conversions > from the Type::None type. It also removes the impossible-to-* conversions. > > BUG=chromium:638132 > > Committed: https://crrev.com/c83b21ab755f1420b6da85b3ff43d7e96ead9bbe > Cr-Commit-Position: refs/heads/master@{#38883} TBR=mstarzinger@chromium.org,jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:638132 Review-Url: https://codereview.chromium.org/2280613002 Cr-Commit-Position: refs/heads/master@{#38893}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 1, 2016
…hset v8#5 id:180001 of https://codereview.chromium.org/2290333002/ ) Reason for revert: Regressed GC times in v8.infinite_scroll_tbmv2 benchmarks. Original issue's description: > [heap] Simplify heuristics for incremental step size. > > This patch removes the code for speeding up marking. > > Now the step size depends on allocated bytes and > invoked write barriers. > > We also ensure that the step size is large enough to > justify the overhead of interrupting the generated code. > > BUG=chromium:616434 > LOG=NO > > Committed: https://crrev.com/71a793e4b1026e69d4009df0a419fe260fe1a235 > Cr-Commit-Position: refs/heads/master@{#39067} TBR=mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616434 Review-Url: https://codereview.chromium.org/2304613002 Cr-Commit-Position: refs/heads/master@{#39098}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 2, 2016
…loppy mode. (patchset v8#5 id:100001 of https://codereview.chromium.org/2290753003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/9470 Original issue's description: > Allow lexically declared "arguments" in function scope in sloppy mode. > > Lexically declared "arguments" in sloppy mode will throw redeclaration error > currently, this patch fixes it by delaying the declaration of arguments until we > fully parse parameter list and function body. > > BUG=v8:4577 > LOG=N > > Committed: https://crrev.com/70a613dd0a5f5d205b46559b55702764464851fa > Cr-Commit-Position: refs/heads/master@{#39109} TBR=adamk@chromium.org,mythria@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4577 Review-Url: https://codereview.chromium.org/2304853002 Cr-Commit-Position: refs/heads/master@{#39115}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 5, 2016
…80001 of https://codereview.chromium.org/2305573002/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Port RegExp getters and setters > > BUG=v8:5339 > > Committed: https://crrev.com/ac0eb5e05af40e16ae9402bb8a62600b32cc2ec9 > Committed: https://crrev.com/7711b1a16f864ed6ea56fa40274ff3f6287bbe34 > Cr-Original-Commit-Position: refs/heads/master@{#39076} > Cr-Commit-Position: refs/heads/master@{#39088} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5339 Review-Url: https://codereview.chromium.org/2313713002 Cr-Commit-Position: refs/heads/master@{#39176}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 7, 2016
…s://codereview.chromium.org/2314803002/ ) Reason for revert: Breaks arm64 nosnap debug: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/2178 Original issue's description: > [heap] Switch to 500k pages > > BUG=chromium:636331 > R=ulan@chromium.org > > Committed: https://crrev.com/4b618dbf8ec7f0edf377b54b48bf3c852d5e235a > Cr-Commit-Position: refs/heads/master@{#39220} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:636331 Review-Url: https://codereview.chromium.org/2312853005 Cr-Commit-Position: refs/heads/master@{#39229}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 19, 2016
…s://codereview.chromium.org/2334323006/ ) Reason for revert: newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop Original issue's description: > Fix async/await memory leak > > This patch closes a memory leak in async/await where the desugaring > was creating a situation analagous to that described in v8:5002. > Intermediate Promises were being kept alive, so a long-running loop > would cause linear memory usage on the heap. This patch returns > undefined to the 'then' callback passed into PerformPromiseThen > in order to avoid this hazard. Test expectations are fixed to remove > expecting extraneous events which occurred on Promises that are > now not given unnecessarily complex resolution paths before being > thrown away. > > BUG=v8:5390 > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > Cr-Commit-Position: refs/heads/master@{#39479} TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org NOTRY=true BUG=v8:5390 Review-Url: https://codereview.chromium.org/2354473002 Cr-Commit-Position: refs/heads/master@{#39493}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 19, 2016
…dereview.chromium.org/2354473002/ ) Reason for revert: Relanding with faster-running test Original issue's description: > Revert of Fix async/await memory leak (patchset v8#5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > Reason for revert: > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > Original issue's description: > > Fix async/await memory leak > > > > This patch closes a memory leak in async/await where the desugaring > > was creating a situation analagous to that described in v8:5002. > > Intermediate Promises were being kept alive, so a long-running loop > > would cause linear memory usage on the heap. This patch returns > > undefined to the 'then' callback passed into PerformPromiseThen > > in order to avoid this hazard. Test expectations are fixed to remove > > expecting extraneous events which occurred on Promises that are > > now not given unnecessarily complex resolution paths before being > > thrown away. > > > > BUG=v8:5390 > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > Cr-Commit-Position: refs/heads/master@{#39479} > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > NOTRY=true > BUG=v8:5390 > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > Cr-Commit-Position: refs/heads/master@{#39493} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403002 Cr-Commit-Position: refs/heads/master@{#39508}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 19, 2016
…ps://codereview.chromium.org/2348403002/ ) Reason for revert: Still causes issues on bot (sometimes!) Original issue's description: > Reland of Fix async/await memory leak (patchset #1 id:1 of https://codereview.chromium.org/2354473002/ ) > > Reason for revert: > Relanding with faster-running test > > Original issue's description: > > Revert of Fix async/await memory leak (patchset v8#5 id:80001 of https://codereview.chromium.org/2334323006/ ) > > > > Reason for revert: > > newly introduced test async-await-loop times out: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/10894/steps/Ignition%20-%20turbofan%20%28flakes%29/logs/async-await-loop > > > > Original issue's description: > > > Fix async/await memory leak > > > > > > This patch closes a memory leak in async/await where the desugaring > > > was creating a situation analagous to that described in v8:5002. > > > Intermediate Promises were being kept alive, so a long-running loop > > > would cause linear memory usage on the heap. This patch returns > > > undefined to the 'then' callback passed into PerformPromiseThen > > > in order to avoid this hazard. Test expectations are fixed to remove > > > expecting extraneous events which occurred on Promises that are > > > now not given unnecessarily complex resolution paths before being > > > thrown away. > > > > > > BUG=v8:5390 > > > > > > Committed: https://crrev.com/a0ba18e9634c5e2d439033ab61a77cff54f9af35 > > > Cr-Commit-Position: refs/heads/master@{#39479} > > > > TBR=adamk@chromium.org,caitp@igalia.com,littledan@chromium.org > > NOTRY=true > > BUG=v8:5390 > > > > Committed: https://crrev.com/196db1999da130019bbf8e3bd65977f840e8afaf > > Cr-Commit-Position: refs/heads/master@{#39493} > > TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > BUG=v8:5390 > > Committed: https://crrev.com/e51482f01f26e0013e6377e85c4d2c41900e403c > Cr-Commit-Position: refs/heads/master@{#39508} TBR=adamk@chromium.org,caitp@igalia.com,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5390 Review-Url: https://codereview.chromium.org/2348403003 Cr-Commit-Position: refs/heads/master@{#39512}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 23, 2016
…atchset v8#5 id:80001 of https://codereview.chromium.org/2367593003/ ) Reason for revert: Failing on the main waterfall again (again for typedarray, even tho it passed trybots?): https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/11515/steps/Check/logs/typedarray Original issue's description: > [turbofan] ChangeFloat64ToTagged shouldn't canonicalize. > > This matches current Crankshaft/fullcodegen behavior more closely and > thus reduces the chances that we run into unnecessary polymorphism due > to the field representation tracking in our object model. > > R=jarin@chromium.org > BUG=v8:5267 > > Committed: https://chromium.googlesource.com/v8/v8/+/6a939714e991ebf10d56ddbd2869325cca99c0ef > Committed: https://crrev.com/ee158e6c4cc896479a32245432a3c2fdd31bcb73 > Cr-Commit-Position: refs/heads/master@{#39692} TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5267 Review-Url: https://codereview.chromium.org/2367963002 Cr-Commit-Position: refs/heads/master@{#39694}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 26, 2016
v8#5 id:80001 of https://codereview.chromium.org/2358133004/ ) Reason for revert: Blocks roll: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10075 Original issue's description: > [stubs] Port String.prototype.substring to TurboFan > > BUG=v8:5415 > > Committed: https://crrev.com/cc37dff7ba21345b3a867a86127a208e34a3f707 > Cr-Commit-Position: refs/heads/master@{#39717} TBR=ishell@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5415 Review-Url: https://codereview.chromium.org/2369003002 Cr-Commit-Position: refs/heads/master@{#39724}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 27, 2016
…patchset v8#5 id:80001 of https://codereview.chromium.org/2367603002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10100 See also: https://github.com/v8/v8/wiki/Blink%20layout%20tests Original issue's description: > [tracing] Support ConvertableToTraceFormat argument type. > > Drive-by: Use perfect forwarding for AddTraceEvent arguments. > > BUG=406277 > > Committed: https://crrev.com/dcac49af485fe5d4c0027f153901435dbb29c232 > Cr-Commit-Position: refs/heads/master@{#39742} TBR=jochen@chromium.org,caseq@chromium.org,fmeawad@chromium.org,alph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=406277 Review-Url: https://codereview.chromium.org/2371103002 Cr-Commit-Position: refs/heads/master@{#39750}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 29, 2016
…8#5 id:80001 of https://codereview.chromium.org/2375793002/ ) Reason for revert: Suspect for causing win64 debug problems: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12646 Original issue's description: > [modules] Properly initialize declared variables. > > Before evaluating a module, all variables declared at the top-level > in _any_ of the modules in the dependency graph must be initialized. > This is observable because a module A can access a variable imported > from module B (e.g. a function) at a point when module B's body hasn't > been evaluated yet. > > We achieve this by implementing modules internally as generators with > two states (not initialized, initialized). > > R=adamk@chromium.org > BUG=v8:1569 > > Committed: https://crrev.com/f4dfb6fbe1cdd9a0f287a1a9c496e1f69f6f5d20 > Cr-Commit-Position: refs/heads/master@{#39871} TBR=adamk@chromium.org,mstarzinger@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:1569 Review-Url: https://codereview.chromium.org/2379063002 Cr-Commit-Position: refs/heads/master@{#39873}
targos
referenced
this pull request
in nodejs/v8
Sep 30, 2016
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 5, 2016
… (patchset v8#5 id:80001 of https://codereview.chromium.org/2384113002/ ) Reason for revert: Tanks the world. Original issue's description: > [turbofan] Osr value typing + dynamic type checks on entry. > > This introduces a new OsrGuard node that is inserted during graph building > to guard the inferred type of the OSR value. > > The type of the OSR value is inferred by running the typer before OSR > deconstruction, and then taking the type from the phi that takes the > OSR value. After the deconstruction, we throw the types away. > > At the moment we only support the SignedSmall OSR type and we always > pick the tagged representation. Later, we might want to support more > types (such as Number) and pick better representations (int32/float64). > > This CL also removes the OSR deconstruction tests because they build > unrealistic graph (no effect chain, no loop termination). I considered > adding the effect chains to the tests, but this would make the tests > even more brittle. > > Committed: https://crrev.com/1f5dc90a900d222da44bee3eff171a2ba1e3c076 > Cr-Commit-Position: refs/heads/master@{#39971} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2395783002 Cr-Commit-Position: refs/heads/master@{#39985}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 6, 2016
…. (patchset v8#5 id:80001 of https://codereview.chromium.org/2384113002/ )" Fixes: - Remove OsrGuards on frame specialization (for asm.js). - Handle the rename in the walk for native context. - Fix LoadContext effect wiring for Osr context chains. Review-Url: https://codereview.chromium.org/2388303006 Cr-Commit-Position: refs/heads/master@{#40021}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Oct 7, 2016
…e segment pool (patchset v8#5 id:160001 of https://codereview.chromium.org/2348303002/ ) Reason for revert: related to roll blocker: https://codereview.chromium.org/2400343002/ Original issue's description: > Replaced different means of zone pooling/reusing by one zone segment pool > > BUG=v8:5409 > > Committed: https://crrev.com/a124feb0760896c8be61de08004a08c3bc9b4b3f > Committed: https://crrev.com/fc840361e357a571c709e0239ae82cc089800b3f > Cr-Original-Commit-Position: refs/heads/master@{#39633} > Cr-Commit-Position: refs/heads/master@{#40048} TBR=mstarzinger@chromium.org,verwaest@chromium.org,heimbuef@google.com NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2401163002 Cr-Commit-Position: refs/heads/master@{#40099}
targos
referenced
this pull request
in nodejs/v8
Nov 5, 2016
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 5, 2016
…chset v8#5 id:100001 of https://codereview.chromium.org/2459903003/ ) Reason for revert: Speculative revert for blocking roll: https://codereview.chromium.org/2473003006/ E.g.: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/331898 Original issue's description: > [Tracing] Use TracingCategoryObserver in gc statistics > > This patch is a follow-up patch to enable gc statistics to use > TracingCategoryObserver. > > Previously we need to pass --track_gc_object_stats to v8 if we want to enable > gc statistics in tracing. In this patch, we introducce an integer flag > FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats > will set it to 0x01, tracing will set it to 0x10 when we start tracing and > reset the bit when we stop tracing. > > BUG=v8:5590 TBR=fmeawad@chromium.org,mlippautz@chromium.org,lpy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5590 Review-Url: https://codereview.chromium.org/2477143002 Cr-Commit-Position: refs/heads/master@{#40785}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 10, 2016
…patchset v8#5 id:80001 of https://codereview.chromium.org/2479123002/ ) Reason for revert: speculative revert to fix https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Mac%20GC%20Stress/builds/9646/steps/Mjsunit%20%28flakes%29/logs/debug-scopes Original issue's description: > Compiling an array literal should be context-independent. > > We are removing use of the debugger context. When the debugger triggers > compilation, we may not have a context from which to create a JSArray. > > R=ishell@chromium.org TBR=ishell@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2481363009 Cr-Commit-Position: refs/heads/master@{#40906}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 23, 2016
…s (patchset v8#5 id:100001 of https://codereview.chromium.org/2504403005/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/2526573002/ Original issue's description: > [stubs] KeyedStoreGeneric: inline dictionary property stores > > For dictionary-mode receivers, the KeyedStoreGeneric stub can store > properties directly in most cases. Doing so avoids the need to have > an entry in the stub cache for every map/property combination. > > Committed: https://crrev.com/af168e330e95c4460fd1bb7734f0e9a750f2e748 > Cr-Commit-Position: refs/heads/master@{#41185} TBR=ishell@chromium.org,rmcilroy@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2528583002 Cr-Commit-Position: refs/heads/master@{#41207}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Nov 24, 2016
…chset v8#5 id:80001 of https://codereview.chromium.org/2526783002/ ) Reason for revert: Need to revert previous CL because of Android compile error, and this one depends in it. Original issue's description: > [base] Define CHECK comparison for signed vs. unsigned > > The current CHECK/DCHECK implementation fails statically if a signed > value is compared against an unsigned value. The common solution is to > cast on each caller, which is tedious and error-prone (might hide bugs). > This CL implements signed vs. unsigned comparisons by executing up to > two comparisons. For example, if i is int32_t and u is uint_32_t, a > DCHECK_LE(i, u) would create the check > i <= 0 || static_cast<uint32_t>(i) <= u. > For checks against constants, at least one of the checks can be removed > by compiler optimizations. > > The tradeoff we have to make is to sometimes silently execute an > additional comparison. And we increase code complexity of course, even > though the usage is just as easy (or even easier) as before. > > The compile time impact seems to be minimal: > I ran 3 full compilations for Optdebug on my local machine, one time on > the current ToT, one time with this CL plus http://crrev.com/2524093002. > Before: 143.72 +- 1.21 seconds > Now: 144.18 +- 0.67 seconds > > In order to check that the new comparisons are working, I refactored > some DCHECKs in wasm to use the new magic. > > R=bmeurer@chromium.org, titzer@chromium.org > > Committed: https://crrev.com/5925074a9dab5a8577766545b91b62f2c531d3dc > Cr-Commit-Position: refs/heads/master@{#41275} TBR=ishell@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2531533003 Cr-Commit-Position: refs/heads/master@{#41277}
cameni
pushed a commit
to Outerra/v8
that referenced
this pull request
Nov 30, 2016
Revision: 06f8e87 BUG=chromium:658267 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=gsathya@chromium.org Review URL: https://codereview.chromium.org/2512413002 . Cr-Commit-Position: refs/branch-heads/5.6@{v8#5} Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f659-refs/heads/master@{#41014}
hubot
pushed a commit
that referenced
this pull request
Dec 1, 2016
…ttps://codereview.chromium.org/2533813002/ ) Reason for revert: Breaks CI dbg builder: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20builder/builds/13817 Original issue's description: > [build] Use MSVS 2015 by default. > > BUG=chromium:603131 > LOG=y > > Committed: https://crrev.com/6b9c49cac101d1a373ae1a098b7959f8aff848ac > Cr-Commit-Position: refs/heads/master@{#41407} TBR=jochen@chromium.org,vogelheim@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:603131 Review-Url: https://codereview.chromium.org/2538493007 Cr-Commit-Position: refs/heads/master@{#41409}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Dec 8, 2016
… (patchset v8#5 id:80001 of https://codereview.chromium.org/2555243002/ ) Reason for revert: gc-stress failures Original issue's description: > [wasm] Fix location for error in asm.js ToNumber conversion > > In the asm.js code translated to wasm, we call imported functions via a > WASM_TO_JS stub, which first calls the function and then calls ToNumber > on the return value. Exceptions can happen in both calls. > We were only ever reporting the location of the function call, whereas > asm.js code executed via turbofan reported the location of the type > coercion operator ("+" on "+foo()" or "|" on "foo()|0"). > > This CL implements the same behaviour for asm.js code translated to > wasm. The following is changed: > - the AsmWasmBuilder records the parent node when descending on a binary > operator (also "+foo()" is represented by a binary operation). > - it stores not one location per call in the source position side > table, but two (one for the call, one for the parent which does the > type coercion). > - the wasm compiler annotates the source positions "0" and "1" to the > two calls in the WASM_TO_JS wrapper (only if the module origin is > asm.js). > - during stack trace generation (in the StackTraceIterator), when we > move from the WASM_TO_JS frame to the WASM frame, we remember at which > call inside the WASM_TO_JS wrapper we are, and encode this information > in the generated caller state, used for the WASM frame. > - the same information is also stored in the FrameArray which is used > to reconstruct the stack trace later. > > R=titzer@chromium.org, bradnelson@chromium.org > CC=jgruber@chromium.org > BUG=v8:4203,v8:5724 > > Committed: https://crrev.com/94cd46b55e24fa2bb7b06b3da4d5ba7f029bc262 > Cr-Commit-Position: refs/heads/master@{#41599} TBR=bradnelson@chromium.org,mstarzinger@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203,v8:5724 Review-Url: https://codereview.chromium.org/2563613003 Cr-Commit-Position: refs/heads/master@{#41601}
hubot
pushed a commit
that referenced
this pull request
Dec 14, 2016
TBR=machenbach@chromium.org NOTRY=True NOPRESUBMIT=True BUG= Review-Url: https://codereview.chromium.org/2574073004 Cr-Commit-Position: refs/heads/gnumb-test/cq@{#5} Cr-Branched-From: 5c49df2-refs/heads/master@{#41618}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes landmine work on OpenBSD. I haven't detected any negative effects from
this, but I haven't used it extensively.