Skip to content

fix: augment vue rather than @vue/runtime-core #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BobbieGoede merged 2 commits into from
Aug 16, 2024
Merged

fix: augment vue rather than @vue/runtime-core #217

BobbieGoede merged 2 commits into from
Aug 16, 2024

Conversation

@danielroe
Copy link
Contributor

@danielroe danielroe commented Aug 16, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In line with vuejs/router#2295 and nuxt/nuxt#28542, this moves to augment vue rather than @vue/runtime core.

This is now officially recommended in the docs and it must be done by all libraries or it will break types for other libraries.

📝 Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

danielroe
danielroe commented Aug 16, 2024
View reviewed changes
@danielroe danielroe mentioned this pull request Aug 16, 2024
Merged
@BobbieGoede
Copy link
Member

BobbieGoede commented Aug 16, 2024

Thanks! We'll find out later if @vue/runtime-dom needs changing as well 😅

@BobbieGoede BobbieGoede merged commit eb7c01d into vueuse:main Aug 16, 2024
@danielroe danielroe deleted the vue-augment branch August 16, 2024 13:54
@Gypsophyllite Gypsophyllite mentioned this pull request Aug 29, 2024
Closed
@matteoscaramuzza
Copy link

matteoscaramuzza commented Sep 2, 2024

When is planned to release a new version that will include this fix?
Because I'd like to fix this problem in our component library, but without this fix there are some problems with builds.

Thank you.

@Tomut0 Tomut0 mentioned this pull request Sep 27, 2024
Merged
@mjbullman mjbullman mentioned this pull request Sep 28, 2024
Merged
@Tomut0 Tomut0 mentioned this pull request Oct 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe @BobbieGoede @matteoscaramuzza