fix: make DeFi positions screen scrollable (#3239)#4029
Merged
Conversation
Add vertical scroll to BaseDeFiPositionsScreen so content is accessible on smaller devices where the Circle USDC amount and buttons may not fit. Co-Authored-By: aminsato <Amin.saradar@yahoo.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughA vertical scrolling modifier was added to the root Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@app/src/main/java/com/vultisig/wallet/ui/screens/v2/defi/BaseDeFiPositionsScreen.kt`:
- Around line 44-47: Remove the nested verticalScroll from the inner tab content
components: locate StakingTabContent, BondedTabContent, and LpTabContent and
remove their Modifier.verticalScroll(rememberScrollState()) so they no longer
create inner scrollables under the root Column that already uses
Modifier.verticalScroll(rememberScrollState()); if those tabs need minimum
bounds instead, replace the scroll modifier with layout constraints such as
fillMaxWidth().heightIn(min = X.dp) on the inner Column to preserve sizing
without enabling a nested scroll.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f03e2fc4-3699-485f-bbb9-daa4400c2935
📒 Files selected for processing (1)
app/src/main/java/com/vultisig/wallet/ui/screens/v2/defi/BaseDeFiPositionsScreen.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseDeFiPositionsScreenso content is accessible on smaller devices where the Circle USDC amount and buttons don't fit on screenFixes #3239
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit