data/src/main/kotlin/com/vultisig/wallet/data/usecases/InitializeThorChainNetworkIdUseCase.kt (1)

20-29: ⚡ Quick win

Consider removing the hasVaults() + getAll() double read

Line 21 and Line 53 both hit the repository. You can read vaults once and derive both checks from that list, which reduces I/O and avoids state drift between calls.

Diff suggestion

 override suspend fun invoke() {
-    if (!vaultRepository.hasVaults()) {
+    val vaults = vaultRepository.getAll()
+    if (vaults.isEmpty()) {
         Timber.d("Skipping THORChain network id init: no vaults")
         return
     }

-    if (!isThorChainEnabledInAnyVault()) {
+    if (!vaults.any { vault -> vault.coins.any { it.chain == Chain.ThorChain } }) {
         Timber.d("Skipping THORChain network id init: no vault uses THORChain")
         return
     }
@@
-    private suspend fun isThorChainEnabledInAnyVault(): Boolean =
-        vaultRepository.getAll().any { vault -> vault.coins.any { it.chain == Chain.ThorChain } }
+    // helper can be removed if not reused

Also applies to: 52-53

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@data/src/main/kotlin/com/vultisig/wallet/data/usecases/InitializeThorChainNetworkIdUseCase.kt`
around lines 20 - 29, Read the vaults once instead of calling
vaultRepository.hasVaults() and then isThorChainEnabledInAnyVault(); in
InitializeThorChainNetworkIdUseCase.invoke() call vaultRepository.getAll() into
a local variable, check if that list is empty to replace hasVaults(), and use
that same list to determine if any vault uses THORChain (the logic currently in
isThorChainEnabledInAnyVault()) before proceeding; remove the separate
hasVaults() call to avoid double repository access and possible state drift.

data/src/test/kotlin/com/vultisig/wallet/data/usecases/InitializeThorChainNetworkIdUseCaseImplTest.kt (1)

51-62: ⚡ Quick win

Tighten branch assertion with repository interaction checks

Since this test targets the “vaults exist but none use THORChain” branch, also verify getAll() is called once (and hasVaults() once) to make the branch intent explicit.

Diff suggestion

         useCase()

+        coVerify(exactly = 1) { vaultRepository.hasVaults() }
+        coVerify(exactly = 1) { vaultRepository.getAll() }
         coVerify(exactly = 0) { thorChainRepository.getCachedNetworkChainId() }
         coVerify(exactly = 0) { thorChainRepository.fetchNetworkChainId() }
         assertEquals("default-id", ThorChainHelper.THORCHAIN_NETWORK_ID)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@data/src/test/kotlin/com/vultisig/wallet/data/usecases/InitializeThorChainNetworkIdUseCaseImplTest.kt`
around lines 51 - 62, Update the test "skips fetch and cache when no vault uses
THORChain" to assert repository interactions explicitly: after calling
useCase(), add coVerify(exactly = 1) { vaultRepository.hasVaults() } and
coVerify(exactly = 1) { vaultRepository.getAll() } so the branch where vaults
exist but none use THORChain is tightened while keeping the existing coVerify
checks for thorChainRepository.getCachedNetworkChainId() and
fetchNetworkChainId().

data/src/test/kotlin/com/vultisig/wallet/data/usecases/InitializeThorChainNetworkIdUseCaseImplTest.kt (1)

81-88: ⚡ Quick win

Assert repository interactions in the fetch-failure test as well.

Right now this test only asserts the final state. Adding call-count checks will ensure the fetch-failure branch is actually exercised (and not silently skipped in a future regression).

Proposed test hardening

     `@Test`
     fun `keeps cached value when fetch fails`() = runTest {
         coEvery { vaultRepository.getAll() } returns listOf(vaultWithChains(Chain.ThorChain))
         coEvery { thorChainRepository.getCachedNetworkChainId() } returns "thorchain-cached"
         coEvery { thorChainRepository.fetchNetworkChainId() } throws RuntimeException("boom")
 
         useCase()
 
+        coVerify(exactly = 1) { vaultRepository.getAll() }
+        coVerify(exactly = 1) { thorChainRepository.getCachedNetworkChainId() }
+        coVerify(exactly = 1) { thorChainRepository.fetchNetworkChainId() }
         assertEquals("thorchain-cached", ThorChainHelper.THORCHAIN_NETWORK_ID)
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@data/src/test/kotlin/com/vultisig/wallet/data/usecases/InitializeThorChainNetworkIdUseCaseImplTest.kt`
around lines 81 - 88, Update the test "keeps cached value when fetch fails" in
InitializeThorChainNetworkIdUseCaseImplTest to verify repository interactions so
the failure branch is exercised: after invoking useCase(), add coVerify checks
that vaultRepository.getAll() was called once,
thorChainRepository.getCachedNetworkChainId() was called once, and
thorChainRepository.fetchNetworkChainId() was called once (use coVerify(exactly
= 1) for each) to assert the fetch was attempted and the cached value was read.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes