Fix fetching Balance on every screen#3162
Merged
Merged
Conversation
Contributor
WalkthroughReworked asynchronous flow composition in ChainTokensViewModel. Replaced onCompletion-based lifecycle with onEach for refreshing state management, introduced List.hasNullAccount() extension for account validation, moved error handling earlier in the chain, and reorganized data preparation sequencing. Changes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@app/src/main/java/com/vultisig/wallet/ui/models/ChainTokensViewModel.kt`:
- Around line 232-235: The current placement of .catch in ChainTokensViewModel
is before the second combine, so exceptions during the UI-state mapping pipeline
(the second combine block that builds the view state) bypass the catch and never
call updateRefreshing(false); move the .catch to after the second combine (i.e.,
after the mapping that constructs the UI state) or add an additional
catch/finally around the second combine/mapping so that updateRefreshing(false)
is always invoked on error; reference the combine/catch chain inside the Flow in
ChainTokensViewModel and ensure updateRefreshing(false) is called in every error
path.
🧹 Nitpick comments (1)
app/src/main/java/com/vultisig/wallet/ui/models/ChainTokensViewModel.kt (1)
398-400: Consider a more descriptive function name.The name
hasNullAccountsuggests checking for nullAccountobjects in the list, but it actually checks for accounts with nulltokenValueorfiatValue. A name likehasIncompleteAccount()orhasUnloadedBalances()would better convey the intent.✏️ Suggested rename
- private fun List<Account>.hasNullAccount() = any { + private fun List<Account>.hasIncompleteAccount() = any { it.tokenValue == null || it.fiatValue == null }And update the call site on line 227:
- updateRefreshing(it.accounts.hasNullAccount()) + updateRefreshing(it.accounts.hasIncompleteAccount())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes #3148
Which feature is affected?
Checklist
Screenshots (if applicable):
Additional context
Summary by CodeRabbit
Refactor
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.