Skip to content

fix: keysign password screen spacing per Figma (#3444)#3566

Merged
johnnyluo merged 1 commit into
mainfrom
fix/ui-3444-keysign-password-spacing
Mar 17, 2026
Merged

fix: keysign password screen spacing per Figma (#3444)#3566
johnnyluo merged 1 commit into
mainfrom
fix/ui-3444-keysign-password-spacing

Conversation

@rkokhatskyi
Copy link
Copy Markdown
Collaborator

@rkokhatskyi rkokhatskyi commented Mar 17, 2026 •
edited by coderabbitai Bot
Loading

Summary

  • Lock icon → title spacing: 20dp → 10dp
  • Title → divider spacing: 20dp → 12dp
  • Hint section → button spacing: 12dp → 10dp

Closes #3444

Before / After

Before After
Before After

Test plan

  • Open keysign password screen and verify spacing matches Figma
  • Verify password hint toggle still works correctly

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Optimized vertical spacing throughout the password entry screen for a more compact and visually refined interface.

@rkokhatskyi @claude
fix: keysign password screen spacing to match Figma
94d2d2c 
Lock icon to title: 20dp → 10dp
Title to divider: 20dp → 12dp
Hint to button: 12dp → 10dp

Closes #3444

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 17, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2ba0a135-5832-4142-852e-aeb7f7844ae7

📥 Commits

Reviewing files that changed from the base of the PR and between bb5a611 and 94d2d2c.

📒 Files selected for processing (1)
  • app/src/main/java/com/vultisig/wallet/ui/screens/keysign/KeysignPasswordScreen.kt
📝 Walkthrough

Walkthrough

Adjusted vertical spacing in the KeysignPasswordScreen's password sheet component to align with design specifications. Three UiSpacer values were reduced: icon-to-title gap from 20.dp to 10.dp, title-to-content gap from 20.dp to 12.dp, and hint-to-button gap from 12.dp to 10.dp.

Changes

Cohort / File(s) Summary
UI Spacing Adjustments
app/src/main/java/com/vultisig/wallet/ui/screens/keysign/KeysignPasswordScreen.kt		 Reduced vertical spacing in KeysignPasswordSheetContent at three locations to tighten layout and match design specifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Spaces tight, the spacing's right,
Where lock icons dance with delight,
Ten dots here, twelve there, ten once more,
The sheet now gleams like never before! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adjusting spacing on the keysign password screen to align with Figma specifications.
Linked Issues check ✅ Passed The PR successfully addresses all spacing requirements from issue #3444: lock icon→title spacing reduced to 10dp, title→divider spacing tightened to 12dp, and hint→button spacing adjusted to 10dp.
Out of Scope Changes check ✅ Passed All changes are directly related to the UI spacing adjustments specified in issue #3444. No unrelated modifications were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ui-3444-keysign-password-spacing
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

johnnyluo
johnnyluo approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@johnnyluo johnnyluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnnyluo johnnyluo merged commit 2ba0b4a into main Mar 17, 2026
2 checks passed
@johnnyluo johnnyluo deleted the fix/ui-3444-keysign-password-spacing branch March 17, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnnyluo johnnyluo johnnyluo approved these changes

@aminsato aminsato Awaiting requested review from aminsato aminsato is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UI Mismatch: KeysignPasswordScreen - Spacing between lock icon and title differs

2 participants

@rkokhatskyi @johnnyluo