T8595: add AGENTS.md + Copilot symlink for the vyos-org central Mergify baseline by andamasov · Pull Request #11 · vyos/mergify

andamasov · 2026-05-16T12:38:27Z

Summary

Adds AGENTS.md at repo root with a .github/copilot-instructions.md symlink to ../AGENTS.md, completing AGENTS.md fleet coverage for the vyos-org central Mergify baseline.

Content diverges from VyOS-Networks/mergify — see "Cross-repo context" for the rationale on the unified single-rule shape used here (vs the two-rule shape on the Networks side).

Authority: T8595, with T8782 / IS-432 context.

Local CodeRabbit (Phase 0 per WD-1334): 2 findings, both classified as symlink-deref false positives — CodeRabbit reviewed .github/copilot-instructions.md as if it were a standalone file rather than a symlink to ../AGENTS.md. Findings flagged "heading mismatch" and "Parent (this file) phrasing"; in AGENTS.md (the actual file) both are correct. Pushback rather than edit.

Test plan

CodeRabbit auto-review (post-flip-to-ready) is clean
Copilot review (manual @copilot review) is clean
Maintainers approval before merge

🤖 Generated by robots

…fy baseline Authority: T8595 (AGENTS.md fleet rollout). 🤖 Generated by [robots](https://vyos.io)

coderabbitai · 2026-05-16T12:38:34Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d2a8c582-0b5e-43c5-867b-08665e818e06

📥 Commits

Reviewing files that changed from the base of the PR and between 1c18ffc and 8642233.

📒 Files selected for processing (2)

.github/copilot-instructions.md
AGENTS.md

📜 Recent review details

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:37.320Z
Learning: Agent tools should be stateless and not maintain internal state between calls

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:47.348Z
Learning: PR title and commit-message format must follow: `T<num>: <description>` or `scope: T<num>: <description>`

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:47.348Z
Learning: Default branch must be `production` with public visibility for all VyOS organization repos

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:47.348Z
Learning: Caller authorization for `Mergifyio` slash commands requires comment author to be a Maintainers-team member; outside that team, commands are silently dropped

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:47.348Z
Learning: Support multi-branch backports using one space-separated command (e.g., `Mergifyio backport circinus sagitta`)

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:47.348Z
Learning: Validate `.mergify.yml` edits using `yaml-language-server` (which honours the in-file `$schema` directive) or by opening a draft consumer PR

Learnt from: CR
Repo: vyos/mergify

Timestamp: 2026-05-16T17:49:47.348Z
Learning: Any change merged to `production` branch affects every consumer's next Mergify event immediately; there is no staging environment

🪛 LanguageTool

AGENTS.md

[locale-violation] ~26-~26: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ...e) loads first; per-repo file is merged afterwards. Same-name rules in the child replace t...

(AFTERWARDS_US)

🔍 Remote MCP Context7

Additional facts relevant to reviewing PR `#11`

Mergify supports sharing configuration from another repository via the extends keyword; the extended config is loaded first and local rules can add or override behavior (examples and guidance for extends, combining extended + local config).
Sources: Mergify docs pages (Extend Mergify Configuration; Configuration Sharing).
Mergify changelog notes a specific feature to allow extending configuration from another repo (historical changelog confirming extends behavior).
GitHub Copilot accepts repository-specific instruction files at .github/copilot-instructions.md and also reads AGENTS.md at the repository root; Copilot/CLI can read instructions from multiple locations (including AGENTS.md) and will use both files if present. The docs include guidance for content and purpose of .github/copilot-instructions.md (project overview, conventions, build/test commands).
Sources: GitHub Copilot documentation pages on custom instructions, creating .github/copilot-instructions.md, and Copilot CLI best practices.
Practical implication for this PR: the repository-level symlink .github/copilot-instructions.md → ../AGENTS.md is consistent with documented Copilot behavior (Copilot will read AGENTS.md and/or .github/copilot-instructions.md), so the symlink approach is valid to provide agent instructions without duplicating content.

Tools used: Context7_resolve-library-id, Context7_query-docs.

🔀 Multi-repo context ansible/ansible

[::ansible/ansible::AGENTS.md] AGENTS.md exists at repo root; contains agent guidance (license rules, PR review checklist, CI/test commands, packaging notes). (see file head lines 1-20 and many sections)

[::ansible/ansible::CLAUDE.md:1] CLAUDE.md references AGENTS.md ("- @AGENTS.md").

[::ansible/ansible::test/sanity/code-smell/package-data.py:26,36] Packaging test excludes AGENTS.md from sdist via ignore_patterns tuple (includes 'AGENTS.md') — ensures AGENTS.md is not packaged in sdist/wheel.

Conclusion: The target repo already contains AGENTS.md and references; the PR's addition of AGENTS.md and a symlink for Copilot would mirror an existing pattern in ansible. This is relevant cross-repo context for reviewer awareness.

🔇 Additional comments (2)

AGENTS.md (1)

1-47: LGTM!

.github/copilot-instructions.md (1)

1-1: LGTM!

📝 Walkthrough

Summary by CodeRabbit

Documentation
- Added AGENTS.md describing the org-wide merge baseline, merge/backport conventions, validation approach, and operational guidance for repository management.
- Updated Copilot instructions to reference the new AGENTS.md for contributor and PR formatting guidance.

Walkthrough

Adds AGENTS.md (46 lines) documenting the vyos org Mergify baseline: inheritance semantics, repo divergences, contributor conventions, and operational notes. Updates .github/copilot-instructions.md (1 line) to reference ../AGENTS.md.

Changes

Organization Mergify baseline documentation

Layer / File(s)	Summary
Mergify baseline documentation and tooling instructions `AGENTS.md` (lines 1-46), `.github/copilot-instructions.md` (line 1)	`AGENTS.md` (46 lines) introduces the org-wide `.mergify.yml` baseline: config intent, YAML schema validation/testing, `extends: mergify` inheritance, explicit divergences from `VyOS-Networks/mergify` (unified PR-message `or:` rule and org-specific header paths), contributor conventions (default branch, PR/commit title format, backport conflict handling and author assignment), and operational guidance (rollback, `unqueue` vs `dequeue`, maintainer-only `@Mergifyio` commands). `.github/copilot-instructions.md` now contains a single-line pointer to `../AGENTS.md`.

Possibly related PRs

vyos/mergify#1: Adds AGENTS.md/Copilot documentation describing the same centralized Mergify baseline behavior and related .mergify.yml semantics.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title clearly and specifically summarizes the primary changes: adding AGENTS.md and a Copilot symlink for the vyos-org Mergify baseline.
Description check	✅ Passed	Description is directly related to the changeset, detailing AGENTS.md addition, the Copilot symlink, content divergence rationale, and test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

✨ Simplify code

Create PR with simplified code
Commit simplified code in branch agents-md-T8595

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

andamasov · 2026-05-16T15:23:29Z

@copilot review

Both the project-purpose summary (line 5) and the Conventions note (line 38) incorrectly stated `ignore_conflicts: false`; .mergify.yml has had `ignore_conflicts: true` (with label_conflicts + assignees as compensating controls) since the incident post-mortem. Update both lines to match. Agent-Logs-Url: https://github.com/vyos/mergify/sessions/68cbfb22-2a97-46af-b2fd-4161c6236f74 Co-authored-by: andamasov <12631358+andamasov@users.noreply.github.com>

Copilot · 2026-05-16T15:25:40Z

@copilot review

Review complete. One real finding fixed (8642233):

AGENTS.md — stale ignore_conflicts: false references (×2)
Both the project-purpose summary and the Conventions note incorrectly stated ignore_conflicts: false. .mergify.yml has had ignore_conflicts: true (with label_conflicts: backport-conflict + assignees: ["{{ author }}"] as compensating controls) since the incident post-mortem. Both lines updated to match the actual config.

Everything else looks correct:

Symlink committed as gitlink (mode 120000), resolves cleanly to ../AGENTS.md ✓
Cross-repo context rationale for the single-rule toggle shape is accurate ✓
unqueue / requeue / multi-branch backport notes are correct ✓
CodeRabbit's "heading mismatch" and "Parent (this file)" findings remain pushback — in the actual AGENTS.md source both are correct; those were symlink-deref false positives as described in the PR ✓

andamasov · 2026-05-16T15:33:22Z

@copilot review

Copilot · 2026-05-16T15:34:12Z

@copilot review

No new findings. Current state (HEAD 8642233) is clean:

AGENTS.md is factually consistent with .mergify.yml (ignore_conflicts: true, label_conflicts: backport-conflict, assignees: ["{{ author }}"]) ✓
Symlink committed as gitlink mode 120000 → ../AGENTS.md ✓
Cross-repo context, single-rule toggle rationale, command restriction notes — all accurate ✓
CodeRabbit's two prior findings remain valid pushback (symlink-deref false positives) ✓

andamasov · 2026-05-16T17:18:07Z

@coderabbitai review

coderabbitai · 2026-05-16T17:18:13Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

andamasov · 2026-05-16T17:49:20Z

@coderabbitai full review

coderabbitai · 2026-05-16T17:49:26Z

✅ Actions performed

Full review triggered.

T8595: add AGENTS.md + Copilot symlink for the vyos-org central Mergi…

9269bf9

…fy baseline Authority: T8595 (AGENTS.md fleet rollout). 🤖 Generated by [robots](https://vyos.io)

Copilot started work on behalf of andamasov May 16, 2026 15:23 View session

Copilot finished work on behalf of andamasov May 16, 2026 15:25

Copilot started work on behalf of andamasov May 16, 2026 15:33 View session

Copilot finished work on behalf of andamasov May 16, 2026 15:34

andamasov marked this pull request as ready for review May 16, 2026 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

T8595: add AGENTS.md + Copilot symlink for the vyos-org central Mergify baseline#11

T8595: add AGENTS.md + Copilot symlink for the vyos-org central Mergify baseline#11
andamasov wants to merge 2 commits into
productionfrom
agents-md-T8595

andamasov commented May 16, 2026 •

edited by atlassian Bot

Loading

Uh oh!

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Additional facts relevant to reviewing PR `#11`

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Uh oh!

andamasov commented May 16, 2026

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

andamasov commented May 16, 2026

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

andamasov commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026

Uh oh!

andamasov commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

andamasov commented May 16, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

coderabbitai Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional facts relevant to reviewing PR #11

Summary by CodeRabbit

Walkthrough

Changes

Possibly related PRs

Uh oh!

andamasov commented May 16, 2026

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

andamasov commented May 16, 2026

Uh oh!

Copilot AI commented May 16, 2026

Uh oh!

andamasov commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026

Uh oh!

andamasov commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

andamasov commented May 16, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Additional facts relevant to reviewing PR `#11`