Skip to content

Add Samoa holidays#1914

Merged
arkid15r merged 9 commits into
vacanza:devfrom
kasya:add-samoa-holidays
Aug 15, 2024
Merged

Add Samoa holidays#1914
arkid15r merged 9 commits into
vacanza:devfrom
kasya:add-samoa-holidays

Conversation

@kasya

@kasya kasya commented Aug 13, 2024

Copy link
Copy Markdown
Contributor

Proposed change

Add Samoa holidays

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@kasya kasya force-pushed the add-samoa-holidays branch from 8c2fc41 to 1e141a9 Compare August 13, 2024 02:12
@codecov

codecov Bot commented Aug 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (96823e8) to head (f41e6d8).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1914   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       186    +1     
  Lines        11263     11289   +26     
  Branches      1785      1785           
=========================================
+ Hits         11263     11289   +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kasya kasya mentioned this pull request Aug 13, 2024
Closed
KJhellico
KJhellico reviewed Aug 14, 2024
View reviewed changes

@KJhellico KJhellico left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasya , it's great: 150 countries, a significant number! 👍
Please take a look at a few suggestions. :)

Comment thread holidays/countries/samoa.py Outdated
Comment thread holidays/countries/samoa.py Outdated
Comment thread holidays/countries/samoa.py Outdated
Comment thread holidays/countries/samoa.py Outdated
@kasya kasya force-pushed the add-samoa-holidays branch from 720f59c to bffcc14 Compare August 15, 2024 00:25
@kasya

kasya commented Aug 15, 2024

Copy link
Copy Markdown
Contributor Author

@kasya , it's great: 150 countries, a significant number! 👍 Please take a look at a few suggestions. :)

@KJhellico Thanks for the review! 👍🏼

KJhellico
KJhellico previously approved these changes Aug 15, 2024
View reviewed changes

@KJhellico KJhellico left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

arkid15r
arkid15r reviewed Aug 15, 2024
View reviewed changes

@arkid15r arkid15r left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @kasya!

@KJhellico is right -- 150 countries is a huge milestone! We move slowly but we make a good progress!

This LGTM, just needs make snapshot update before the merge.

@sonarqubecloud

sonarqubecloud Bot commented Aug 15, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge August 15, 2024 22:18
@arkid15r arkid15r added this pull request to the merge queue Aug 15, 2024
Merged via the queue into vacanza:dev with commit 9b0c33a Aug 15, 2024
@arkid15r arkid15r deleted the add-samoa-holidays branch August 15, 2024 22:27
This was referenced Aug 15, 2024
Closed
Merged
@KJhellico KJhellico mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kasya @arkid15r @KJhellico