Skip to content

Conversation

@arkid15r
Copy link
Collaborator

Proposed change

This is an PoC version of -sbom.json file generation. For more granular control we should use cyclonedx-python-lib.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

This is an PoC version of -sbom.json file generation.
For more granular control we should use `cyclonedx-python-lib`.
@arkid15r arkid15r requested a review from KJhellico as a code owner August 17, 2024 00:38
@sonarqubecloud
Copy link

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Aug 19, 2024
Merged via the queue into vacanza:dev with commit 08f7aac Aug 19, 2024
@arkid15r arkid15r deleted the implement-sbom-generation branch August 19, 2024 16:17
@arkid15r arkid15r mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants