Update Cambodian holidays for 2024 #1936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1936 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 186 186
Lines 11315 11316 +1
Branches 1789 1789
=========================================
+ Hits 11315 11316 +1 ☔ View full report in Codecov by Sentry. |
arkid15r
approved these changes
Aug 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
April 16, 2024 is in fact declared as part of extended "Khmer New Year" (Sangkranta) holidays as seen in here (Web Archive Copy).
This also updates the list of years when such holiday started on APR 14 (instead of the usual APR 13) as shown on its Wikipedia page.
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally