Skip to content

Conversation

@Gizsviu
Copy link
Contributor

@Gizsviu Gizsviu commented Aug 27, 2024

Added 2025 Substituted holidays for Hungary according to the NGM ministry.

Proposed change

Added 2025 Substituted holidays for Hungary according to the NGM ministry.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Added 2025 Substituted holidays for Hungary according to the NGM ministry.
@Gizsviu
Copy link
Contributor Author

Gizsviu commented Aug 27, 2024

Hey guys! Thanks for maintaining python-holidays! This is my very first pull request and first interaction with GitHub, and I'm not quite sure about if tests are required for this simple holidays addition. If so I'll figure out to run them.

@codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1aede11) to head (59ef7f4).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1954   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines        11382     11382           
  Branches      1793      1793           
=========================================
  Hits         11382     11382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KJhellico
Copy link
Collaborator

@Gizsviu, thank you for your addition! For tests completeness, it would be useful to add new dates to list here.

@KJhellico KJhellico changed the title Update hungary.py Update HU: add 2025 substituted holidays Aug 27, 2024
Updated test_substituted func with 2025 dates
@sonarqubecloud
Copy link

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to GitHub @Gizsviu!

Your first contribution looks great, thanks for updating HU holidays

@arkid15r arkid15r added this pull request to the merge queue Aug 28, 2024
Merged via the queue into vacanza:dev with commit c7f95f3 Aug 28, 2024
@Gizsviu Gizsviu deleted the patch-1 branch August 28, 2024 06:28
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants