Skip to content

Update pyproject.toml: remove target-version from tool.ruff #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2024
Merged

Update pyproject.toml: remove target-version from tool.ruff #1950

merged 1 commit into from
Aug 23, 2024

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Aug 23, 2024

Proposed change

Remove target-version from tool.ruff.

If you're already using a pyproject.toml file, we recommend project.requires-python instead, as it's based on Python packaging standards, and will be respected by other tools.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@arkid15r arkid15r requested a review from KJhellico as a code owner August 23, 2024 16:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Aug 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (af428f3) to head (ccbfef5).
Report is 3 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       187           
  Lines        11397     11397           
  Branches      1800      1800           
=========================================
  Hits         11397     11397

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Aug 23, 2024
Merged via the queue into vacanza:dev with commit 85bc137 Aug 23, 2024
@arkid15r arkid15r deleted the update-pyproject-toml branch August 23, 2024 17:05
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @KJhellico