Update Germany holidays: add th localization, deprecated non-standard ISO code, add subdivision aliases
#1979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1979 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 188
Lines 11403 11407 +4
Branches 1789 1790 +1
=========================================
+ Hits 11403 11407 +4 ☔ View full report in Codecov by Sentry. |
KJhellico
reviewed
Sep 5, 2024
|
Hmm, seems like we might be able to consolidate this a bit further: |
|
arkid15r
approved these changes
Sep 10, 2024
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
…rd ISO code, add subdivision aliases (vacanza#1979) Co-authored-by: Arkadii Yakovets <ark@cho.red>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR includes 3 changes for Germany 🇩🇪 holidays:
BYPcode. Catholic municipalities in Bavaria will instead need to include theCATHOLICcategory to mimic the previously implemented behavior.EN,MI, HASC) #1952 by adding "Bayern (Katholisch)" as a subregion too? I'm open to all suggestions here.thlocalization. (Checked with https://bangkok.diplo.de/th-th/botschaft/oeffnungszeiten/1670002 )Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally