Skip to content

Add Frances Xavier Cabrini Day for United States, Colorado #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2024
Merged

Add Frances Xavier Cabrini Day for United States, Colorado #1995

merged 2 commits into from
Sep 16, 2024

Conversation

@e2thenegpii
Copy link
Contributor

@e2thenegpii e2thenegpii commented Sep 15, 2024

Proposed change

Add the Colorado state holiday Francis Xavier Cabrini Day

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@github-actions github-actions bot added the test label Sep 15, 2024
@codecov
Copy link

codecov bot commented Sep 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b4c9ccf) to head (4ebd5b8).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #1995   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11407     11409    +2     
  Branches      1790      1791    +1     
=========================================
+ Hits         11407     11409    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

arkid15r
arkid15r approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this @e2thenegpii!

This is going to today's v0.57 release.

@arkid15r arkid15r enabled auto-merge September 16, 2024 15:48
@arkid15r arkid15r added this pull request to the merge queue Sep 16, 2024
Merged via the queue into vacanza:dev with commit 1467e72 Sep 16, 2024
@arkid15r arkid15r mentioned this pull request Sep 16, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@e2thenegpii @arkid15r @mstuttgart
Add Frances Xavier Cabrini Day for United States, Colorado (vacanza#1995
4c95b79 
)

Co-authored-by: Arkadii Yakovets <ark@cho.red>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e2thenegpii @arkid15r