Skip to content

Remove deprecated fix-encoding-pragma, add pyupgrade #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2024
Merged

Remove deprecated fix-encoding-pragma, add pyupgrade #2007

merged 3 commits into from
Sep 20, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Sep 20, 2024

Proposed change

This PR switches out fix-encoding-pragma hook for pyupgrade.

I noticed that the fix-encoding-pragma used in make pre-commit is listed as deprecated, as seen here:
Screenshot 2024-09-20 102351

As written in pre-commit-hooks pypl page:

fix-encoding-pragma
Deprecated since py2 is EOL - use pyupgrade instead.

Add # -- coding: utf-8 -- to the top of python files.
To remove the coding pragma pass --remove (useful in a python3-only codebase)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Sep 20, 2024

Unlike the pre-commit results here, I can ascertain that these changes run correctly on my machine.
image

@KJhellico
Copy link
Collaborator

KJhellico commented Sep 20, 2024

It's great update! But we also need to fix tests/test_i10n.py.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

arkid15r
arkid15r approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff, thanks @PPsyrius !

@arkid15r arkid15r enabled auto-merge September 20, 2024 16:18
@arkid15r arkid15r changed the title Removes deprecated fix-encoding-pragma, migrates to pyupgrade Remove deprecated fix-encoding-pragma, add pyupgrade Sep 20, 2024
@codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (34dc910) to head (2ddb2c3).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2007   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11409     11409           
  Branches      1791      1791           
=========================================
  Hits         11409     11409

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r added this pull request to the merge queue Sep 20, 2024
Merged via the queue into vacanza:dev with commit ac7bd8d Sep 20, 2024
31 checks passed
@PPsyrius PPsyrius deleted the fix-encoding-pragma-to-pyupgrade branch September 21, 2024 05:18
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@PPsyrius @arkid15r @mstuttgart
Remove deprecated fix-encoding-pragma, add pyupgrade (vacanza#2007)
970f0a4 
Co-authored-by: Arkadii Yakovets <ark@cho.red>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

script test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @KJhellico @arkid15r