Skip to content

Update apostrophes: change ’ to ' #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2024
Merged

Update apostrophes: change ’ to ' #2016

merged 3 commits into from
Sep 25, 2024

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Sep 24, 2024

Proposed change

Update apostrophes: change ’ to '

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6b1060b) to head (5e4ab74).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2016   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          189       189           
  Lines        11457     11457           
  Branches      1794      1794           
=========================================
  Hits         11457     11457

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico reviewed Sep 25, 2024
View reviewed changes
@arkid15r @KJhellico
Update docs/source/conf.py
dd67ff6 
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
KJhellico
KJhellico previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge September 25, 2024 15:21
@arkid15r arkid15r added this pull request to the merge queue Sep 25, 2024
Merged via the queue into vacanza:dev with commit 0e58e46 Sep 25, 2024
32 checks passed
@arkid15r arkid15r deleted the update-apostrophes branch September 25, 2024 15:38
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@arkid15r @KJhellico @mstuttgart
Update apostrophes: change ’ to ' (vacanza#2016)
5a9b19a 
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees

No one assigned

Labels

doc l10n snapshot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arkid15r @KJhellico