Skip to content

Update Curaçao holidays: add HALF_DAY holidays #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2024
Merged

Update Curaçao holidays: add HALF_DAY holidays #2039

merged 1 commit into from
Oct 6, 2024

Conversation

@KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Oct 5, 2024

Proposed change

Update Curaçao holidays: add HALF_DAY holidays (New Year's Eve).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4665dfc) to head (83a4d71).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2039   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       190           
  Lines        11516     11522    +6     
  Branches      1797      1798    +1     
=========================================
+ Hits         11516     11522    +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius
Copy link
Collaborator

PPsyrius commented Oct 6, 2024

LGTM 🇨🇼

@arkid15r arkid15r added this pull request to the merge queue Oct 6, 2024
Merged via the queue into vacanza:dev with commit ab5816a Oct 6, 2024
32 checks passed
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
Merged
@KJhellico KJhellico deleted the upd-curacao branch October 11, 2024 16:15
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@KJhellico @mstuttgart
Update Curaçao holidays: add HALF_DAY holidays (vacanza#2039)
7cd2781
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PPsyrius PPsyrius PPsyrius approved these changes

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

l10n snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @PPsyrius @arkid15r