Skip to content

Drop Python 3.8 support #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

Drop Python 3.8 support #2042

merged 1 commit into from
Oct 11, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 8, 2024 •
edited
Loading

Proposed change

Drops Python 3.8 support due to its EOL status as of October 7, 2024, upgrades syntax to Python 3.9 standard, and simplifies requirements/tests.txt for numpy.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PPsyrius PPsyrius mentioned this pull request Oct 10, 2024
Merged
arkid15r
arkid15r approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe :)

@arkid15r arkid15r added this pull request to the merge queue Oct 11, 2024
Merged via the queue into vacanza:dev with commit 7335779 Oct 11, 2024
26 checks passed
@PPsyrius PPsyrius deleted the python38_eol branch October 11, 2024 01:48
@KJhellico KJhellico mentioned this pull request Oct 21, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@PPsyrius @mstuttgart
Drop Python 3.8 support (vacanza#2042)
346ba49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

ci doc script test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PPsyrius @arkid15r