Update Vietnam holidays: add th localization
#2060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2060 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 190 190
Lines 11539 11539
Branches 1743 1743
=========================================
Hits 11539 11539 ☔ View full report in Codecov by Sentry. |
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds Thai (th) localization for Vietnam holidays.
Note
As there's no single official translation for Vietnamese Lunar New Year in Thai usage from the government (The Thai embassy in Ho Chi Minh city used English for their holiday's notice), I ended up using
วันตรุษเต๊ตas used by the Voice of Vietnam and the Thai-Vietnamese Friendship Association overวันตรุษเวียตนามandวันตรุษญวน.Type of change
holidaysfunctionality in general)Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally