Skip to content

Add EasternCalendarHolidays to holidays groups #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

Add EasternCalendarHolidays to holidays groups #2062

merged 2 commits into from
Oct 17, 2024

Conversation

@KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Oct 17, 2024

Proposed change

Add EasternCalendarHolidays to holidays groups (optimize commonly used code).

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b0a7ecb) to head (618aee0).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2062   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          190       191    +1     
  Lines        11539     11541    +2     
  Branches      1743      1742    -1     
=========================================
+ Hits         11539     11541    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arkid15r
arkid15r previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring!

@KJhellico KJhellico force-pushed the ref-eastern-holidays branch from 046992f to 618aee0 Compare October 17, 2024 18:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r added this pull request to the merge queue Oct 17, 2024
Merged via the queue into vacanza:dev with commit 15fc197 Oct 17, 2024
29 checks passed
@KJhellico KJhellico deleted the ref-eastern-holidays branch October 17, 2024 19:13
@KJhellico KJhellico mentioned this pull request Oct 21, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@KJhellico @mstuttgart
Add EasternCalendarHolidays to holidays groups (vacanza#2062)
8a08485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@PPsyrius PPsyrius Awaiting requested review from PPsyrius PPsyrius is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KJhellico @arkid15r