Skip to content

Refactor United States tests #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Refactor United States tests #2087

merged 1 commit into from
Oct 29, 2024

Conversation

@KJhellico
Copy link
Collaborator

@KJhellico KJhellico commented Oct 28, 2024

Proposed change

Refactor United States tests.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@github-actions github-actions bot added the test label Oct 28, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b2e6837) to head (42338c1).
Report is 3 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2087   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines        11547     11547           
  Branches      1744      1744           
=========================================
  Hits         11547     11547

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇺🇸

arkid15r
arkid15r reviewed Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@arkid15r arkid15r added this pull request to the merge queue Oct 29, 2024
Merged via the queue into vacanza:dev with commit a484f9a Oct 29, 2024
29 checks passed
@KJhellico KJhellico deleted the ref-us-tests branch October 29, 2024 19:53
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@KJhellico @mstuttgart
Refactor United States tests (vacanza#2087)
b6903c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@PPsyrius PPsyrius PPsyrius approved these changes

Assignees

No one assigned

Labels

test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KJhellico @arkid15r @PPsyrius