Skip to content

Improve .po files "Language-Team" header consistency #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2024
Merged

Improve .po files "Language-Team" header consistency #2098

merged 2 commits into from
Nov 1, 2024

Conversation

@arkid15r
Copy link
Collaborator

@arkid15r arkid15r commented Nov 1, 2024

Proposed change

Update Language-Team header's value format.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@github-actions github-actions bot added the l10n label Nov 1, 2024
@codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ca990d6) to head (653af07).
Report is 2 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2098   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          191       191           
  Lines        11549     11549           
  Branches      1736      1736           
=========================================
  Hits         11549     11549

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkid15r arkid15r linked an issue Nov 1, 2024 that may be closed by this pull request
Language-Team name standardization in l10n files #2094
Closed
KJhellico
KJhellico previously approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge November 1, 2024 16:31
@arkid15r arkid15r requested a review from KJhellico November 1, 2024 16:33
PPsyrius
PPsyrius approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌐

@arkid15r arkid15r added this pull request to the merge queue Nov 1, 2024
Merged via the queue into vacanza:dev with commit 8b546a8 Nov 1, 2024
29 checks passed
@arkid15r arkid15r deleted the update-l10n-headers branch November 1, 2024 17:29
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@arkid15r @mstuttgart
Improve .po files "Language-Team" header consistency (vacanza#2098)
cb3f0ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PPsyrius PPsyrius PPsyrius approved these changes

@KJhellico KJhellico Awaiting requested review from KJhellico KJhellico is a code owner

Assignees

No one assigned

Labels

l10n

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Language-Team name standardization in l10n files

3 participants

@arkid15r @KJhellico @PPsyrius