Skip to content

Fix make l10n removing loc comment for Asarnha Bucha #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix make l10n removing loc comment for Asarnha Bucha #2091

merged 1 commit into from
Oct 29, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 29, 2024 •
edited
Loading

Proposed change

Further fix for #2081 so make l10n command no longer removes the translation comment from Asarnha Bucha localization entry.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (a484f9a) to head (a35e74b).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #2091   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         191      191           
  Lines       11537    11537           
  Branches     1738     1738           
=======================================
  Hits        11535    11535           
  Misses          1        1           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KJhellico
KJhellico approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Oct 29, 2024
Merged via the queue into vacanza:dev with commit 5a853fe Oct 29, 2024
29 checks passed
@PPsyrius PPsyrius deleted the th_asarnha branch October 30, 2024 04:55
@arkid15r arkid15r mentioned this pull request Nov 4, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@PPsyrius @mstuttgart
Fix make l10n removing loc comment for Asarnha Bucha (vacanza#2091)
3c99625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico