Update Unites States holidays: remove Columbus Day from countrywide holidays #2106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 192
Lines 11577 11577
Branches 1741 1741
=========================================
Hits 11577 11577 ☔ View full report in Codecov by Sentry. |
|
Since "Columbus Day" is still observed by Federal Government offices and the US Postal Service even in states that don't observe this i.e. California - I think they should be moved to |
|
I think we need to implement all federal holidays as |
PPsyrius
approved these changes
Nov 6, 2024
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
arkid15r
added a commit
to arkid15r/python-holidays
that referenced
this pull request
Dec 15, 2024
…rywide holidays (vacanza#2106)" This reverts commit e658618.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Update Unites States holidays: remove Columbus Day from countrywide holidays.
Resolves #2103.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green