Update Brunei holidays: 1998-2003, 2006-2025 exact dates#2107
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2107 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 192
Lines 11577 11586 +9
Branches 1741 1746 +5
=========================================
+ Hits 11577 11586 +9 ☔ View full report in Codecov by Sentry. |
KJhellico
reviewed
Nov 5, 2024
KJhellico
left a comment
Collaborator
There was a problem hiding this comment.
It's great research! I have no suggestions, just a few thoughts :)
|
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
3rd day of Eid al-Fitr holidayentries for pre-2012 (an extra date was added in 2012 via( 8 ) JPM/SK/2012before being officially added in all entries from 2013 onwards).Note
These are the list of missing "Surat Keliling Jabatan Perdana Menteri" from Prime Minister Office of Brunei Darussalam's Online Archive (usually referred to as
( [BILLNO] ) JPM/SK/[YEAR]), likely lost media altogether.JPMSK11-2003"Hari-Hari Kelapasan Awam tahun 2004" (Public Holidays in 2004): simply missing from the archives at the moment.JPMSK11-2004"Hari-Hari Kelapasan Awam tahun 2005" (Public Holidays in 2005): the current link is a misplaced Public Holidays announcement for 2006 instead.JPMSK(10?-12?)-2008"Hari-Hari Kelapasan Awam tahun 2009" (Public Holidays in 2009): this is thankfully more recent than other missing entries so a school holidays calendar copy exists, though having the original government source would still be appreciated here.Also, since the accuracy of https://www.timeanddate.com/holidays/brunei/ Islamic holidays entries pre-2023 are now proved to be questionable at best, I would like to remove the prefilled data for 2004 and 2005 for now to restore the
(estimated)suffix for those years if possible. 👀Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green