Update Cambodia holidays: add Peace Day in Cambodia#2108
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2108 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 192
Lines 11577 11579 +2
Branches 1741 1742 +1
=========================================
+ Hits 11577 11579 +2 ☔ View full report in Codecov by Sentry. |
KJhellico
reviewed
Nov 5, 2024
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
|
Collaborator
Author
|
I'm thinking of adding some kind of hidden char remover to the pre-commit later to prevent that from being included in the first place again. 👀 |
arkid15r
approved these changes
Nov 7, 2024
arkid15r
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the cleanup 👍
9 tasks
Merged
mstuttgart
pushed a commit
to multidadosti-erp/python-holidays
that referenced
this pull request
Nov 18, 2024
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green