Add "Brasil, Bolsa, Balcão" ([B]³) holidays #2109
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2109 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 192 193 +1
Lines 11599 11639 +40
Branches 1749 1756 +7
=========================================
+ Hits 11599 11639 +40 ☔ View full report in Codecov by Sentry. |
|
@araggohnxd I've created a PR on your repo with some suggestions inside (testcases refractors, add your name to |
|
@araggohnxd, thank you for your contribution to Holidays! As I can see, this list of BVMF holidays is based on the current list of Brazil holidays. I have just created PR #2113, where I made some changes to holidays of the first half of the 20th century (based on available legal sources). If you have the time and opportunity, I would be grateful if you could review these changes, perhaps I have missed something or misunderstood. Also, you can use info from this PR to add localization of BVMF holidays if you would like to. |
|
@KJhellico AFAIK I don't think our existing |
|
Yeah, I think the next step is indeed adding localization, even though I remember not quite understanding how to do it for financial markets. I'll check out the related PR to see if it can throw some light on the issue for me. |
BVMF suggestions
|
@KJhellico Good job on spotting the Our Lady of Aparecida related law on your PR. I also added some Tiradentes' day sources on this PR, you may want to check that out. I think the feature is pratically done, the only thing I'm not really sure about is the Holy Thursday, because I couldn't find any source backing up its existence as a holiday, other than this resolution from the central bank:
About localization, I couldn't really make it work, so any help is appreciated. |
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
BVMF l10n support
- Remove entity aliases - Clean up existing contents before generation
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
|
There was a problem hiding this comment.
@araggohnxd thanks for adding B3 and bringing more improvements to the snapshot generation with this!
Co-authored-by: PPsyrius <19505219+PPsyrius@users.noreply.github.com> Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com> Co-authored-by: Arkadii Yakovets <ark@cho.red> Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Proposed change
Add "Brasil, Bolsa, Balcão" - Brazil Stock Exchange and Over-the-Counter Market (B3) - to the list of available financial markets holidays.
This is still a work in progress, so I'm opening a draft PR just in case anyone else feels like contributing.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green