Skip to content

Add Portugal subdivision aliases #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 7, 2024
Merged

Add Portugal subdivision aliases #2110

merged 4 commits into from
Nov 7, 2024

Conversation

@dgomes
Copy link
Contributor

@dgomes dgomes commented Nov 6, 2024 •
edited
Loading

Proposed change

Adds alias to each of the subdivisions (districts) in accordance with ISO 3166-2:PT

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@dgomes
Copy link
Contributor Author

dgomes commented Nov 6, 2024

tests pass locally

@codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e658618) to head (4f8661d).
Report is 6 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11577     11589   +12     
  Branches      1741      1747    +6     
=========================================
+ Hits         11577     11589   +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇵🇹

@KJhellico KJhellico changed the title Update portugal.py with subdivisions_aliases Add Portugal subdivision aliases Nov 7, 2024
KJhellico
KJhellico previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

arkid15r
arkid15r reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dgomes thanks for the contribution!

Could you double check PT-20/PT-30 mapping? Thank you!

@dgomes @arkid15r
Apply suggestions from code review
4f8661d 
You are absolutely right, slipped through when I sorted the districts

Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
@dgomes dgomes dismissed stale reviews from KJhellico and PPsyrius via 4f8661d November 7, 2024 17:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@arkid15r arkid15r enabled auto-merge November 7, 2024 17:38
arkid15r
arkid15r reviewed Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the aliases, @dgomes

We also have the AUTHORS file if you're interested.

LGTM

@dgomes
Copy link
Contributor Author

dgomes commented Nov 7, 2024

Thanks for adding the aliases, @dgomes

We also have the AUTHORS file if you're interested.

LGTM

Thank you @arkid15r , maybe when I get the opportunity I try to address #331 and then I can add myself to AUTHORS ;)

@arkid15r arkid15r added this pull request to the merge queue Nov 7, 2024
Merged via the queue into vacanza:dev with commit 1baee5f Nov 7, 2024
29 checks passed
@KJhellico KJhellico mentioned this pull request Nov 18, 2024
Merged
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
@dgomes @arkid15r @mstuttgart
Add Portugal subdivision aliases (vacanza#2110)
959d0c9 
Co-authored-by: Arkadii Yakovets <2201626+arkid15r@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r approved these changes

@KJhellico KJhellico KJhellico left review comments

@PPsyrius PPsyrius PPsyrius left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgomes @arkid15r @KJhellico @PPsyrius