Here is "Neujahrstag". This is an official source, as far as I understand.

Here is "Neujahrstag". This is an official source, as far as I understand.

That's correct, I'm familiar with that document. It is a document which specifies which days are counted as holidays for legal matters, for example to calculate whether you filed claims within the specified period of time.

short answer:
The current spelling of "Neujahrestag" (check the 2nd "e") in the python file is wrong. "Neujahr" is what people actually use. "Neujahrstag" is understood and would be the correct spelling you also find in the referenced document.

long answer:
You won't find "Neujahrestag" (as in the python file) anywhere in that document. The document uses "Neujahrstag", not "Neujahr e stag". Nevertheless what we really call it is "Neujahr", same as for Germany, Austria, Liechtenstein. The document also uses "Fahrtsfest" for Glarus (...subdiv_gl_public...) but we call it "Näfelser Fahrt" (the way it is in the python file). Furthermore the PDF document uses "Mariä Himmelfahrt" and "Mariä Empfängnis" in some places and in others "Maria ..." (ä vs a). The python file uses the traditional spelling throughout which is much more consistent. The PDF document uses the Italian names for Ticino (...ti...), French names for the French-speaking cantons and both French and German for the three cantons officially speaking both languages. The canton of Graubünden (...gr...) officially uses 3 languages: German, Italian and Romansh, but the document only uses German and Italian. (see: https://www.eda.admin.ch/aboutswitzerland/en/home/gesellschaft/sprachen/mehrsprachigkeit.html and https://www.fedlex.admin.ch/eli/cc/2009/821/en#art_21) The python file consistently uses the German names throughout. Switching to localized and even multi-language names could become messy. Besides, the PDF document also clearly states on page 2 that only August 1st is a holiday defined on national level. The other three holidays configured in _populate_public_holidays actually are are not national holiday but holidays defined on cantonal (subdiv) level, albeit they are holidays in all 26 cantons. Also here, changing that in the python file might be counter-productive.

Yes, I mean, let's change it to "Neujahrstag".

@kurtkeller does "Neujahrstag" look like a meet in the middle option?
Thanks for your native language experience input!

Yes, "Neujahrstag" is a good enough compromise.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a4fcbc7) to head (00cce38).
Report is 3 commits behind head on dev.

@@            Coverage Diff            @@
##               dev     #2121   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          192       192           
  Lines        11590     11599    +9     
  Branches      1747      1749    +2     
=========================================
+ Hits         11590     11599    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.