Skip to content

Add Guernsey holidays #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2024
Merged

Add Guernsey holidays #2135

merged 3 commits into from
Nov 22, 2024

Conversation

@PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Nov 21, 2024 •
edited
Loading

Proposed change

Add Guernsey 🇬🇬 holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Nov 21, 2024

I don't think CodeQL appears to be running from the major version changes in #2132

KJhellico
KJhellico reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great! 👍 Just a few small suggestions:

@PPsyrius @KJhellico
[GG} code review improvements
8494dbd 
Co-Authored-By: ~Jhellico <KJhellico@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88f5c65) to head (a2aee5b).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          193       194    +1     
  Lines        11644     11716   +72     
  Branches      1758      1771   +13     
=========================================
+ Hits         11644     11716   +72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@PPsyrius PPsyrius requested a review from KJhellico November 22, 2024 04:10
@arkid15r
Copy link
Collaborator

arkid15r commented Nov 22, 2024

I don't think CodeQL appears to be running from the major version changes in #2132

CodeQL is still there, but CodeCov has some issues (we've discussed it w/ @KJhellico in Slack yesterday).

arkid15r
arkid15r reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r enabled auto-merge November 22, 2024 17:22
KJhellico
KJhellico approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Nov 22, 2024
Merged via the queue into vacanza:dev with commit 1638464 Nov 22, 2024
28 checks passed
@PPsyrius PPsyrius deleted the guernsey_holidays branch November 23, 2024 05:42
@arkid15r arkid15r mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arkid15r arkid15r arkid15r left review comments

@KJhellico KJhellico KJhellico approved these changes

Assignees

No one assigned

Labels

snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PPsyrius @arkid15r @KJhellico