Skip to content

Update KZ holidays: add 2025 special holidays #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2024
Merged

Update KZ holidays: add 2025 special holidays #2167

merged 4 commits into from
Dec 13, 2024

Conversation

@qaziqarta
Copy link
Contributor

@qaziqarta qaziqarta commented Dec 12, 2024

Proposed change

Update KZ holidays: add 2025 special and substituted holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (380b20c) to head (330f0e1).
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff            @@
##               dev     #2167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          194       194           
  Lines        11541     11541           
  Branches      1641      1641           
=========================================
  Hits         11541     11541

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PPsyrius
PPsyrius reviewed Dec 12, 2024
View reviewed changes
PPsyrius
PPsyrius previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇰🇿

KJhellico
KJhellico reviewed Dec 12, 2024
View reviewed changes
@qaziqarta @KJhellico
Update holidays/countries/kazakhstan.py
df55e60 
Co-authored-by: ~Jhellico <KJhellico@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
6.7% Duplication on New Code

See analysis details on SonarQube Cloud

KJhellico
KJhellico approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r enabled auto-merge December 13, 2024 16:34
@arkid15r arkid15r added this pull request to the merge queue Dec 13, 2024
Merged via the queue into vacanza:dev with commit 058b997 Dec 13, 2024
29 checks passed
@KJhellico KJhellico mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KJhellico KJhellico KJhellico approved these changes

@PPsyrius PPsyrius PPsyrius approved these changes

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Assignees

No one assigned

Labels

snapshot test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qaziqarta @KJhellico @PPsyrius @arkid15r