Add HebrewCalendarHolidays to holidays groups, refactor Israel holidays
#2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2186 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 194 195 +1
Lines 11657 11679 +22
Branches 1691 1685 -6
=========================================
+ Hits 11657 11679 +22 ☔ View full report in Codecov by Sentry. |
arkid15r
reviewed
Dec 22, 2024
arkid15r
reviewed
Dec 22, 2024
de94ef7 to
f140153
Compare
|
arkid15r
reviewed
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add
HebrewCalendarHolidaysto holidays groups (for use in other countries with Hebrew holidays); refactor Israel holidays.Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green