Skip to content

Conversation

@tackerfrink
Copy link
Contributor

Proposed change

Add new holiday for US markets. 1/9/2025: Day of Mourning for President Jimmy Carter.
https://apnews.com/article/stock-exchange-closes-jan-9-carter-death-32fe7dcc8546ed98d2408abf8f498b08

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new holidays functionality in general)

Checklist

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc9877b) to head (1500b66).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       195           
  Lines        11763     11762    -1     
  Branches      1700      1699    -1     
=========================================
- Hits         11763     11762    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PPsyrius PPsyrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💹

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r changed the title Financial Holiday - Day of Mourning for President Jimmy Carter Update XNYS: add a Day of Mourning for President Jimmy Carter Jan 1, 2025
@arkid15r arkid15r added this pull request to the merge queue Jan 1, 2025
Merged via the queue into vacanza:dev with commit 71d51f0 Jan 1, 2025
32 checks passed
@arkid15r
Copy link
Collaborator

arkid15r commented Jan 1, 2025

@tackerfrink thank you for the timely update!

@arkid15r arkid15r mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants