Update Thailand holidays: refactor Royal Ploughing Ceremony code#2247
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2247 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 196 196
Lines 11891 11891
Branches 1717 1717
=========================================
Hits 11891 11891 ☔ View full report in Codecov by Sentry. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
As แรกนาขวัญ (Royal Ploughing Ceremony) entries are all manually assigned,
MAY, 13fallback date is no longer needed.Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green