Unify certain holidays names translation#2285
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2285 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 200 200
Lines 12232 12232
Branches 1742 1742
=========================================
Hits 12232 12232 ☔ View full report in Codecov by Sentry. |
arkid15r
reviewed
Feb 11, 2025
arkid15r
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
A couple of questions to clarify:
# Conflicts: # holidays/locale/da/LC_MESSAGES/GL.po # holidays/locale/en_US/LC_MESSAGES/GL.po # snapshots/countries/GL_COMMON.json
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Unify certain holidays names translation: Labor Day, Children's Day (in several variations) etc.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green