Reviewing files that changed from the base of the PR and between cdd6f41 and 0071a86.

• holidays/calendars/thai.py (23 hunks)

holidays/calendars/thai.py (9)

24-89: Great improvements to the Thai Lunar Calendar documentation

The updates to the class docstring significantly enhance the clarity and structure of the documentation. Key improvements include:

• Clearer explanation of the Thai lunar year types and month structure
• Better organization of the holiday list with consistent formatting
• Addition of more detailed festival information like "Buddha's Cremation Day" and "Ok Boun Suang Huea"
• Improved explanation of lunar phases (waxing and waning)

These changes make the documentation much more comprehensive and educational.

---

281-285: Good docstring simplification

The simplified docstring is concise and appropriate for this verification method.

---

289-301: Improved documentation structure

The conversion to the "Args:" and "Returns:" format improves consistency with modern documentation standards and makes the parameter and return value descriptions clearer.

---

314-341: Enhanced holiday documentation for Makha Bucha

The docstring improvements provide greater clarity on how the date is calculated and the variations between calendar types. The "Returns:" section now explicitly mentions what happens with invalid input years.

---

359-385: Clear documentation format for Visakha Bucha

The consistent use of "Args:" and "Returns:" across all methods creates a uniform documentation style that improves readability.

---

403-424: Fixed calculation explanation for Preah Neangkoal

The correction of "Visakha Bucha +4" in line 416 makes the calculation explanation clearer and more precise.

---

431-458: Enhanced docstring for Atthami Bucha (Buddha's Cremation Day)

Good clarification that this is "Buddha's Cremation Day" and maintaining consistency with the documentation pattern.

---

476-500: Improved explanation for Asarnha Bucha calculation

The rephrasing of the calculation explanation makes it easier to understand how the delta days are determined for different year types.

---

513-536: Clear documentation for Khao Phansa

The docstring now has a consistent format and better explains the relation to Asarnha Bucha (+1 day).

Reviewing files that changed from the base of the PR and between 0071a86 and dd3c3c7.

• holidays/calendars/thai.py (23 hunks)

holidays/calendars/thai.py (15)

23-103: Documentation significantly improved and modernized

The docstring for _ThaiLunisolar class has been thoroughly improved with:

• Clearer explanation of the Thai Lunar Calendar types (Pakatimat, Athikawan, Athikamat)
• Better details on month structures and waxing/waning phases
• Comprehensive list of implemented holiday methods with their lunar calendar references
• Additional holiday entries like "Buddha's Cremation Day" and "Ok Boun Suang Huea"

These changes align well with the PR objectives to enhance documentation quality.

---

280-286: Documentation improvement in progress

The docstring for __verify_calendar has been simplified, which is good for a utility method. However, this method may be part of the syntax error chain due to the previous indentation issue.

Once the previous indentation error is fixed, please verify this method works correctly.

🧰 Tools

🪛 Ruff (0.8.2)

280-280: SyntaxError: unindent does not match any outer indentation level

---

281-281: SyntaxError: Expected class, function definition or async function definition after decorator

🪛 GitHub Actions: CI/CD

[error] 281-281: SyntaxError: Expected class, function definition or async function definition after decorator

---

290-302: Documentation format updated to modern standards

The docstring has been updated to use "Args:" and "Returns:" format instead of the older :param and :return style, which aligns with modern Python documentation practices.

---

316-342: Documentation improved for clarity and consistency

The docstring for makha_bucha_date has been improved with:

• Better explanation of calculation logic
• Clarified formatting with modern "Args:" and "Returns:" style
• More detailed parameter descriptions

This change is consistent with the PR's goal of enhancing documentation.

---

361-386: Documentation standardized

The docstring for visakha_bucha_date follows the same improved pattern as other methods, with standardized "Args:" and "Returns:" sections and clearer explanations.

---

405-425: Documentation clarified for Preah Neangkoal method

The explanation of the calculation method has been improved for clarity, particularly the line:
"Or as in simpler terms: 'Visakha Bucha' (Khmer Lunar Calendar) +4" which helps readers quickly understand the relationship between these dates.

---

433-459: Documentation enhanced for Atthami Bucha

The docstring for atthami_bucha_date has been updated with consistent formatting and better explanations. Nice addition of the alternative name "Buddha's Cremation Day" for better context.

---

478-501: Documentation improved with clearer calculation explanation

The docstring for asarnha_bucha_date has been updated with a better explanation of the calculation process and standardized formatting.

---

515-537: Documentation updated for Khao Phansa

The docstring for khao_phansa_date has been standardized to match the documentation style of other methods, improving overall consistency.

---

551-571: Documentation standardized for Boun Haw Khao Padapdin

The documentation has been updated to follow the same improved pattern as other methods, with standardized "Args:" and "Returns:" sections.

---

585-605: Documentation enhanced with clarification

The docstring for boun_haw_khao_salark_date has been updated with improved parameter descriptions and return value explanation.

---

619-639: Documentation improved for Pchum Ben date calculation

The docstring has been updated with better formatting and clearer explanation of the calculation logic.

---

653-673: Documentation enhanced for Ok Phansa

The docstring for ok_phansa_date has been updated to follow the modern documentation style with clear "Args:" and "Returns:" sections.

---

687-707: Fixed name and updated documentation for Boun Suang Heua

The method name in the docstring has been corrected from boun_suang_heua_date to Ok Boun Suang Huea with additional clarification of its alternative name.

---

721-741: Documentation standardized for Loy Krathong

The docstring for loy_krathong_date has been updated with the same improved pattern as other methods, maintaining consistency throughout the class.

Reviewing files that changed from the base of the PR and between 6b41e1c and 10a859d.

• holidays/calendars/thai.py (23 hunks)

• GitHub Check: Test build on windows-latest

holidays/calendars/thai.py (6)

24-120: Improved documentation is well structured and comprehensive.

The updated docstring provides excellent context about the Thai Lunar Calendar with clear explanations of the calendar types, month structure, and implemented holiday methods. The organization into logical sections makes it easier to understand the complex calendar system.

---

286-294: Documentation formatting is consistent with modern standards.

The updated docstring correctly uses "Args:" and "Returns:" format, which aligns with modern Python documentation standards. This improves readability and makes the interface clearer.

---

307-319: Good clarification of return value behavior.

The improved docstring clearly explains when the method returns None (when the year is outside the working scope), which is important for error handling in dependent code.

---

333-359: Clear documentation of algorithm logic with supporting detail.

The documentation nicely explains both the holiday's alternative names and the calculation logic, which is valuable for maintainers who need to understand the implementation details.

---

422-442: Corrected calculation explanation.

The updated docstring improves the explanation of the calculation for Preah Neangkoal, particularly clarifying that it uses the Khmer Lunar Calendar for calculations.

---

115-119:

✅ Verification successful

Code example might need proper indentation for documentation rendering.

The code example appears to be formatted correctly in the source, but based on previous comments, there might be issues with how this renders in documentation.

---

🏁 Script executed:

#!/bin/bash
# Check how code examples appear in the rendered documentation
fd -t f -e md -e yml "\.md$|mkdocs\.yml$" . | xargs grep -l "ThaiLunisolar" | xargs cat

Length of output: 72943

---

Documentation Rendering of ThaiLunisolar Example Verified
After checking the rendered documentation output, the ThaiLunisolar example appears correctly indented and formatted. No indentation issues were found in the final rendered docs, so no changes are required here.

Reviewing files that changed from the base of the PR and between 75ec05c and 12c0087.

• holidays/calendars/thai.py (23 hunks)

holidays/calendars/thai.py (15)

287-295: Documentation style modernized

The docstring follows the modern "Args:" and "Returns:" format, which is more consistent with the rest of the codebase and current Python best practices.

---

300-300: Concise docstring improvement

The simplified docstring is clearer and more direct.

---

308-320: Improved method documentation

The updated docstring provides clearer information on the method's purpose and return values, following the modern documentation format.

---

334-360: Enhanced holiday calculation documentation

The docstring clarifies the calculation process for Makha Bucha and includes proper format for parameter and return value documentation.

---

379-404: Improved Visakha Bucha documentation

The updated docstring maintains clarity and follows the modern documentation style with "Args:" and "Returns:" sections.

---

423-443: Fixed formula description in Preah Neangkoal documentation

The corrected documentation accurately describes this as the "4th Waning Day" which matches the calculation.

---

451-477: Buddha's Cremation Day documentation updated

Clear documentation of the Atthami Bucha calculation with proper formatting for parameters and return values.

---

496-519: Improved Asarnha Bucha documentation

The docstring contains more accurate information about this holiday and properly follows the modern documentation format.

---

533-555: Enhanced Khao Phansa documentation

The updated docstring provides clearer information and follows the modern documentation style.

---

569-589: Updated Boun Haw Khao Padapdin documentation

Documentation follows the established format and provides clearer descriptions.

---

603-623: Improved Boun Haw Khao Salark documentation

The docstring follows the modern format and provides a clear description of this holiday.

---

637-657: Enhanced Pchum Ben documentation

The documentation follows the established format and provides clear descriptions.

---

671-691: Updated Ok Phansa documentation

The documentation clearly describes this holiday and follows the modern Python docstring format.

---

705-725: Corrected method name in Boun Suang Heua documentation

The docstring now accurately reflects the correct holiday name and provides clearer information about the calculation.

---

739-759: Improved Loy Krathong documentation

The updated documentation follows the established format and provides clearer information.