Update Singapore holidays: 2025 Polling Day on May 3rd by PPsyrius · Pull Request #2487 · vacanza/holidays

PPsyrius · 2025-04-22T05:05:50Z

Proposed change

Add Singapore's 2025 polling day.
Update special holidays sources from 2020 onwards to use the https://mom.gov.sg source.
Add every special holiday entry to test_special_holiday .

Resolves #2486.

Type of change

New country/market holidays support (thank you!)
Supported country/market holidays update (calendar discrepancy fix, localization)
Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
Dependency update (version deprecation/pin/upgrade)
Bugfix (non-breaking change which fixes an issue)
Breaking change (a code change causing existing functionality to break)
New feature (new holidays functionality in general)

Checklist

I've followed the contributing guidelines
I've successfully run make check, all checks and tests are green

coderabbitai · 2025-04-22T05:05:57Z

Summary by CodeRabbit

New Features
- Added Polling Day on May 3, 2025, as a public holiday for Singapore.
Documentation
- Updated references to official sources for Singapore's polling day public holidays.
Tests
- Expanded test coverage to include the new 2025 Polling Day and additional special holiday dates for Singapore.

Walkthrough

This update adds May 3, 2025, as "Polling Day" to Singapore's public holiday data. The change updates the source references to official Ministry of Manpower press releases, extends the special holidays dictionary in the Singapore holidays module, adds the new holiday to the Singapore holidays JSON snapshot, and expands the test suite to cover the new date and other special holidays.

Changes

Files/Paths	Change Summary
holidays/countries/singapore.py	Updated references for polling day holidays to official sources; added 2025 polling day to special holidays.
snapshots/countries/SG_COMMON.json	Added "2025-05-03" as "Polling Day" to the Singapore holidays data.
tests/countries/test_singapore.py	Extended tests to include 2025 polling day and additional special holiday assertions.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Add 3 May 2025 as a public holiday for Singapore, "Polling Day" (#2486)	✅

Suggested labels

l10n, snapshot, test

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc951b7 and d82b277.

📒 Files selected for processing (3)

holidays/countries/singapore.py (2 hunks)
snapshots/countries/SG_COMMON.json (1 hunks)
tests/countries/test_singapore.py (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

tests/countries/test_singapore.py (1)

tests/common.py (1)

assertHoliday (150-152)

🔇 Additional comments (5)

snapshots/countries/SG_COMMON.json (1)

956-956: Added Polling Day holiday for 2025 correctly.

The new holiday entry for "Polling Day" on May 3, 2025 has been properly added to the Singapore holidays list, following the same format as other holiday entries in the JSON file.

holidays/countries/singapore.py (2)

310-312: References updated to official sources.

Good improvement replacing the single reference with multiple official Ministry of Manpower press releases for polling day holidays. Using official government sources increases reliability.

329-329: Added 2025 Polling Day consistently.

The polling day for 2025 has been properly added to the special_public_holidays dictionary, maintaining the same format as previous entries (year: month, day, name).

tests/countries/test_singapore.py (2)

189-189: 2025 test case properly updated.

The test_2025 method has been correctly updated to include the assertion for "Polling Day" on May 3, 2025, maintaining consistency with other holiday test cases.

201-210: Comprehensive special holidays testing.

The test_special_holidays method has been enhanced to test all special holidays, including the newly added 2025 Polling Day. This ensures all special holidays are properly handled by the library.

Previously this method likely had a simpler implementation, and now it's been expanded to test each special holiday individually, which improves test coverage.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2025-04-22T05:06:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2025-04-22T05:07:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc951b7) to head (d82b277).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff            @@
##               dev     #2487   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          214       214           
  Lines        13527     13527           
  Branches      1928      1928           
=========================================
  Hits         13527     13527

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkid15r

LGTM 👍

KJhellico

LGTM.

Update Singapore holidays: 2025 Polling Day on May 3rd

d82b277

PPsyrius requested review from KJhellico and arkid15r as code owners April 22, 2025 05:05

github-actions Bot added snapshot test labels Apr 22, 2025

arkid15r reviewed Apr 22, 2025

View reviewed changes

arkid15r enabled auto-merge April 22, 2025 05:23

KJhellico approved these changes Apr 22, 2025

View reviewed changes

arkid15r added this pull request to the merge queue Apr 22, 2025

Merged via the queue into vacanza:dev with commit ad51a04 Apr 22, 2025

PPsyrius deleted the 2025_sg_polling_day branch April 23, 2025 02:52

arkid15r mentioned this pull request May 5, 2025

v0.72 #2527

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Singapore holidays: 2025 Polling Day on May 3rd#2487

Update Singapore holidays: 2025 Polling Day on May 3rd#2487
arkid15r merged 1 commit into
vacanza:devfrom
PPsyrius:2025_sg_polling_day

PPsyrius commented Apr 22, 2025

Uh oh!

coderabbitai Bot commented Apr 22, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud Bot commented Apr 22, 2025

Uh oh!

codecov Bot commented Apr 22, 2025 •

edited

Loading

Uh oh!

arkid15r left a comment

Uh oh!

KJhellico left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PPsyrius commented Apr 22, 2025

Proposed change

Type of change

Checklist

Uh oh!

coderabbitai Bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Assessment against linked issues

Suggested labels

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sonarqubecloud Bot commented Apr 22, 2025

Quality Gate passed

Uh oh!

codecov Bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkid15r left a comment

Choose a reason for hiding this comment

Uh oh!

KJhellico left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Apr 22, 2025 •

edited

Loading

codecov Bot commented Apr 22, 2025 •

edited

Loading