Reviewing files that changed from the base of the PR and between ad51a04 and ecb9d84.

• holidays/calendars/buddhist.py (4 hunks)
• holidays/calendars/chinese.py (9 hunks)
• holidays/calendars/hindu.py (3 hunks)
• holidays/countries/indonesia.py (2 hunks)
• holidays/countries/south_korea.py (2 hunks)
• holidays/countries/vietnam.py (2 hunks)
• holidays/groups/chinese.py (2 hunks)
• scripts/calendar/asian_generator.py (8 hunks)
• snapshots/countries/ID_COMMON.json (1 hunks)
• snapshots/countries/VN_COMMON.json (8 hunks)
• tests/calendars/test_chinese.py (1 hunks)
• tests/countries/test_vietnam.py (1 hunks)

scripts/calendar/asian_generator.py (10)

43-44: Correctly updated lunar month data for precise date calculations.

The hexadecimal value correction in G_LUNAR_MONTH_DAYS array ensures accurate lunar date calculations, which is essential for determining holidays in the Chinese lunisolar calendar.

---

57-59: Verified lunar data corrections around 1920.

These hex value corrections align with historical lunar calendar data, improving accuracy for this period.

---

63-63: Corrected critical lunar data for 1920.

The hex value update ensures correct lunar month length calculations for this year.

---

132-132: Fixed lunar month data for 1990.

This correction ensures accurate lunar-to-gregorian date conversions for holidays in this time period.

---

168-168: Corrected lunar data for 2020s period.

The updated hex value improves accuracy for modern holiday date calculations.

---

232-232: Fixed lunar data for 2090.

This correction is important for far-future holiday date calculations.

---

242-243: Corrected lunar data for year 2100.

These hex value updates complete the accurate representation of the lunisolar calendar through 2100.

---

247-253: Extended calendar end year and adjusted date boundaries.

The extension from 2099 to 2100 with corresponding end date adjustments aligns with the PR objective to extend date support up to year 2100.

---

359-362: Added time zone documentation for regional calendar variants.

This documentation clearly maps the UTC offsets for different regions, providing context for the three variants (Vietnamese, Chinese, Korean) mentioned in the PR objectives.

---

390-390: Extended date processing range to match new boundary.

The update to process years through 2100 ensures complete coverage for the extended date range.

holidays/calendars/buddhist.py (3)

149-149: Fixed Vesak holiday date for 2025.

Updating from May 11 to May 12 reflects the corrected lunisolar calendar calculations.

---

224-224: Added Vesak holiday support for year 2100.

This addition properly extends Buddhist calendar holiday support to match the extended calendar range in the generator.

---

427-427: Added Vesak May date for year 2100.

This addition correctly extends the alternative Vesak calculation used by some countries through 2100.

snapshots/countries/ID_COMMON.json (1)

1200-1200: Corrected Lunar New Year date for 2030 in Indonesia.

The date change from February 3rd to February 2nd aligns with using the Vietnamese calendar variant (UTC+7) for Indonesia, as specified in the PR objectives.

tests/countries/test_vietnam.py (1)

72-72: Corrected Hung Kings' Day date for 2009.

The date change from April 5th to April 4th ensures the test aligns with the Vietnamese calendar variant calculations, maintaining test consistency with the implementation changes.

tests/calendars/test_chinese.py (1)

13-20: Well-structured test for calendar validation.

This test effectively verifies that the _ChineseLunisolar class properly rejects invalid calendar types by raising a ValueError. This supports the multi-calendar enhancement that adds regional calendar variants (Chinese, Korean, Vietnamese).

holidays/countries/indonesia.py (2)

20-20: Appropriate import for the Vietnam calendar constant.

Adding the import of VIETNAM_CALENDAR from the Chinese calendars module supports the use of the correct regional calendar variant.

---

76-78: Correct calendar specification for Indonesia.

Using the VIETNAM_CALENDAR parameter is appropriate since Indonesia shares the UTC+7 timezone with Vietnam, as mentioned in the PR objectives. This ensures that Chinese lunar calendar holidays in Indonesia will use the correct regional variant.

holidays/calendars/hindu.py (4)

138-138: Date correction for historical accuracy.

The change corrects the Diwali date for 1914, aligning with the PR's focus on improving calendar accuracy.

---

144-144: Date correction for historical accuracy.

The change corrects the Diwali date for 1920, contributing to better historical precision.

---

324-324: Extended date support through 2100.

Adding the Diwali date for 2100 meets the PR objective to extend calendar date support.

---

1185-1185: Extended date support through 2100.

Adding the Thaipusam date for 2100 completes the calendar extension and ensures consistency across all holiday types.

snapshots/countries/VN_COMMON.json (9)

123-126: Calendar date correction for Vietnamese lunar calendar.

These date adjustments for Lunar New Year 1965 align with the Vietnamese calendar variant (UTC+7), ensuring accurate holiday calculations specific to Vietnam.

---

147-150: Calendar date correction for Vietnamese lunar calendar.

These adjustments for Lunar New Year 1968 ensure consistency with the Vietnamese calendar calculations.

---

155-158: Calendar date correction for Vietnamese lunar calendar.

These adjustments for Lunar New Year 1969 ensure consistency with the Vietnamese calendar calculations.

---

283-286: Calendar date correction for Vietnamese lunar calendar.

These adjustments for Lunar New Year 1985 ensure consistency with the Vietnamese calendar calculations.

---

484-489: Calendar date correction for Vietnamese lunar calendar.

These adjustments for Lunar New Year 2007 ensure consistency with the Vietnamese calendar calculations.

---

511-511: Correction to Hung Kings' Commemoration Day.

This adjustment from April 5 to April 4 for 2009 aligns with the PR's objective to fix calendar discrepancies for Vietnam holidays.

---

791-797: Calendar date correction for Vietnamese lunar calendar.

These adjustments for Lunar New Year 2030 ensure consistency with the Vietnamese calendar calculations.

---

896-896: Calendar date correction for Vietnamese calendar.

The adjustment to Hung Kings' Commemoration Day in 2037 helps maintain calendar accuracy for future dates.

---

909-909: Calendar date correction for Vietnamese calendar.

The adjustment to Hung Kings' Commemoration Day in 2038 helps maintain calendar accuracy for future dates.

holidays/countries/vietnam.py (2)

16-17: Looks good – dedicated calendar constant keeps logic explicit.
The explicit VIETNAM_CALENDAR import clarifies intent and avoids implicit defaults.

---

62-68: Constructor wiring aligns correctly with new calendar API.
Calling ChineseCalendarHolidays.__init__(self, calendar=VIETNAM_CALENDAR) hits the updated signature and preserves previous behaviour. No hidden side‑effects spotted.

holidays/groups/chinese.py (1)

16-17: Selective import keeps public surface tidy.
Pulling only _ChineseLunisolar and CHINESE_CALENDAR avoids namespace bloat.

holidays/countries/south_korea.py (1)

17-18: Import is minimal and purposeful.
Keeps module dependencies lean.

holidays/calendars/chinese.py (2)

1324-1331: Lookup order looks sound

exact → calendar‑override → default is intuitive; the verification guard prevents accidental fall‑through. Implementation matches the pattern used in other calendar modules.

---

1333-1349: Public helpers remain backward‑compatible

Passing calendar=None keeps the old call signature while enabling overrides—good call. No action needed.

Reviewing files that changed from the base of the PR and between ecb9d84 and 4e16011.

• holidays/calendars/chinese.py (9 hunks)
• holidays/countries/vietnam.py (2 hunks)
• scripts/calendar/asian_generator.py (8 hunks)

holidays/countries/vietnam.py (2)

16-17: 👍 Good catch on the constant rename

Importing VIETNAMESE_CALENDAR aligns Vietnam with the new multi‑calendar mechanism.
No further action needed here.

---

62-64: Side‑effect of the prefix mismatch

Because the override tables in chinese.py still start with VIETNAM_CALENDAR_…, the line below will currently not load the Vietnamese‑specific dates:

ChineseCalendarHolidays.__init__(self, calendar=VIETNAMESE_CALENDAR)

Once the tables are renamed (see earlier comment), this call will behave as intended.
Until then, Vietnam will use fallback dates. Keep an eye on the fix.

scripts/calendar/asian_generator.py (2)

359-362: Appreciate the explicit timezone comments

The quick legend (UTC+7/8/9) makes the data blocks far easier to grok.
Nice touch.

---

246-254:

✅ Verification successful

Array length vs. declared range

END_YEAR is bumped to 2100, and one more element was appended to G_LUNAR_MONTH_DAYS.
A quick sanity check that the list length equals END_YEAR - START_YEAR + 1 protects against off‑by‑one slips.

shell
#!/usr/bin/env bash

Ensure lunar data array length matches configured year span.

fd --extension py G_LUNAR_MONTH_DAYS -x
python - <<'PY'
import re, sys, pathlib, ast, textwrap
path = pathlib.Path("scripts/calendar/asian_generator.py")
source = path.read_text()
tree = ast.parse(source)
for node in ast.walk(tree):
if isinstance(node, ast.Assign) and any(
getattr(t, "id", None) == "G_LUNAR_MONTH_DAYS" for t in node.targets
):
count = len(node.value.elts)
start = next(n for n in ast.walk(tree)
if isinstance(n, ast.Assign) and n.targets[0].id == "START_YEAR").value.n
end = next(n for n in ast.walk(tree)
if isinstance(n, ast.Assign) and n.targets[0].id == "END_YEAR").value.n
print(f"entries={count}, span={end-start+1}")
sys.exit(0)
PY

Expected output: `entries=200, span=200`

---

🏁 Script executed:

```shell

Length of output: 139

---

🏁 Script executed:

#!/usr/bin/env bash
# Show the relevant lines around the assignments
sed -n '230,300p' scripts/calendar/asian_generator.py

# Count G_LUNAR_MONTH_DAYS entries and compare to END_YEAR - START_YEAR + 1
python3 - <<'PY'
import ast, pathlib
path = pathlib.Path('scripts/calendar/asian_generator.py')
src = path.read_text()
tree = ast.parse(src)

start = end = entries = None
for node in ast.walk(tree):
    if isinstance(node, ast.Assign):
        for t in node.targets:
            name = getattr(t, "id", None)
            if name == "START_YEAR":
                start = node.value.n if hasattr(node.value, "n") else node.value.value
            elif name == "END_YEAR":
                end = node.value.n if hasattr(node.value, "n") else node.value.value
            elif name == "G_LUNAR_MONTH_DAYS":
                entries = len(node.value.elts)

if None in (start, end, entries):
    print("Error: could not find START_YEAR, END_YEAR, or G_LUNAR_MONTH_DAYS")
else:
    span = end - start + 1
    print(f"entries={entries}, span={span}")
PY

Length of output: 2661

---

🏁 Script executed:

#!/usr/bin/env bash
# Locate where G_LUNAR_MONTH_DAYS is defined
grep -n "G_LUNAR_MONTH_DAYS" scripts/calendar/asian_generator.py

# Verify START_YEAR, END_YEAR, and count of G_LUNAR_MONTH_DAYS entries
python3 - <<'PY'
import ast, pathlib, sys
path = pathlib.Path('scripts/calendar/asian_generator.py')
src = path.read_text()
tree = ast.parse(src)

start = end = entries = None
for node in ast.walk(tree):
    if isinstance(node, ast.Assign):
        for t in node.targets:
            # module‐level tuple for lunar data
            if isinstance(t, ast.Name) and t.id == 'G_LUNAR_MONTH_DAYS':
                entries = len(node.value.elts)
            # instance attributes in __init__
            if isinstance(t, ast.Attribute) and t.attr == 'START_YEAR':
                if isinstance(node.value, ast.Constant):
                    start = node.value.value
            if isinstance(t, ast.Attribute) and t.attr == 'END_YEAR':
                if isinstance(node.value, ast.Constant):
                    end = node.value.value

if None in (start, end, entries):
    print(f"Error: could not find all values: start={start}, end={end}, entries={entries}")
    sys.exit(1)

span = end - start + 1
print(f"entries={entries}, span={span}")
PY

Length of output: 449

---

🏁 Script executed:

#!/usr/bin/env bash
# Verify that G_LUNAR_MONTH_DAYS entry count matches END_YEAR - START_YEAR + 1
python3 - <<'PY'
import ast, pathlib, sys

path = pathlib.Path('scripts/calendar/asian_generator.py')
src = path.read_text()
tree = ast.parse(src)

start = end = entries = None
for node in ast.walk(tree):
    if isinstance(node, ast.Assign):
        for t in node.targets:
            # capture the tuple literal on self.G_LUNAR_MONTH_DAYS
            if isinstance(t, ast.Attribute) and t.attr == 'G_LUNAR_MONTH_DAYS':
                if isinstance(node.value, ast.Tuple):
                    entries = len(node.value.elts)
            # capture START_YEAR and END_YEAR constants
            if isinstance(t, ast.Attribute) and t.attr == 'START_YEAR':
                start = node.value.value if isinstance(node.value, ast.Constant) else None
            if isinstance(t, ast.Attribute) and t.attr == 'END_YEAR':
                end = node.value.value if isinstance(node.value, ast.Constant) else None

if None in (start, end, entries):
    print(f"Error: could not find all values: start={start}, end={end}, entries={entries}")
    sys.exit(1)

span = end - start + 1
print(f"entries={entries}, span={span}")
PY

Length of output: 33

---

Sanity check passed: G_LUNAR_MONTH_DAYS length matches the year span
Verified entries=200, span=200—no off‑by‑one errors detected.