Add Cabo Verde holidays#2654
Merged
Merged
Conversation
# Conflicts: # README.md # holidays/countries/__init__.py
…hanges from the dev branch and resolved conflicts by accepting the new branch changes.
Contributor
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughCabo Verde (Cape Verde) holiday support was added to the codebase. This includes a new country module, registration, translations in five languages, subdivision support, documentation updates, and comprehensive holiday date snapshots for all regions and municipalities from 1976 to 2050. Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
♻️ Duplicate comments (2)
holidays/locale/es/LC_MESSAGES/CV.po (1)
73-75: Use “Día de Navidad” for naming consistency (comment repeated).
Most holiday translations begin with “Día …”, so keeping the same pattern here would read better.holidays/locale/fr/LC_MESSAGES/CV.po (1)
61-64: Duplicate: trim “Fête de” to stay inline with French style guide
Same remark as in the earlier review: the project omits the leading “Fête de”.-msgstr "Fête de l'Indépendance Nationale" +msgstr "Jour de l'Indépendance"
KJhellico
reviewed
Jul 19, 2025
Signed-off-by: Prateekshit Jaiswal <67361301+Prateekshit73@users.noreply.github.com>
|
KJhellico
approved these changes
Jul 20, 2025
arkid15r
reviewed
Jul 21, 2025
arkid15r
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for completing this @Prateekshit73!
Closed
This was referenced Jul 21, 2025
Merged
Merged
This was referenced Jul 24, 2025
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add Cabo Verde holidays.
Resolves #1159.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green