-
-
Notifications
You must be signed in to change notification settings - Fork 561
Add Python 3.14 (beta) to CI/CD #2650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
Summary by CodeRabbit
WalkthroughPython 3.14 support was added to both the CI/CD workflow and tox configuration. The test matrix in the workflow and the tox environment list now include Python 3.14, expanding the range of Python versions tested. No other changes were made. Changes
Possibly related PRs
Suggested labels
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2650 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 271 271
Lines 16205 16205
Branches 2190 2190
=========================================
Hits 16205 16205 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/ci-cd.yml(1 hunks)tox.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms (2)
- GitHub Check: Test Python 3.14 on windows-latest
- GitHub Check: Test Python 3.14 on ubuntu-latest
🔇 Additional comments (1)
.github/workflows/ci-cd.yml (1)
87-87: Approve Python 3.14 in the CI matrix
Including'3.14'here ensures tests run on the upcoming Python release across all supported OSes. The existingallow-prereleases: truesetting covers the beta channel.
|
I've already tried adding 3.14, but numpy doesn't have wheels for Windows yet, and the built version doesn't work. 🤷♂️ |
I see, so retrying is useless here... So what's the plan here -- just wait until it's supported? I guess I'll convert it to draft until then... |
(from numpy/numpy#29062) |
|
Python 3.14 RC1 is ready, and numpy 2.3.2 too. Seems all is ok. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
requirements/tests.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Test build on windows-latest
- GitHub Check: Test build on macos-latest
- GitHub Check: Test build on ubuntu-latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed change
Add Python 3.14 (beta) to CI/CD. Final release expected on 2025-10-07.
Type of change
holidaysfunctionality in general)Checklist
make check, all checks and tests are green